-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-meetings): resolved guest issue forbidden error #3861
Conversation
@Parimala032 |
@pagour98 hidden messages are in the console are third party issues parv and this hidden messages you can able to see in the github.io (meetings sample app) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we get a review from WWC folks? Please check the comments as well
packages/@webex/plugin-meetings/test/unit/spec/meetings/index.js
Outdated
Show resolved
Hide resolved
No @mkesavan13 for the master branch it's not needed |
@Parimala032 Workflow: github_checks is failing, pls check... |
@pagour98 the workflow github_checks should actually no longer be there. We just haven't removed them. These are checks happening on CircleCI, which we no longer use for the pipeline. Actions are the only steps we need to check. |
COMPLETES #< SPARK-561608 >
This pull request addresses
This PR is used to address the 403 Forbidden issues that the user had seen in the meetings widgets sample app. When a user clicks on the register button in the logs it shows a 403 forbidden error but the user can join the meeting which means these are unnecessary logs that should be avoided. So, we are fixing this issue first in the kitchen sink app so that the meetings widgets get fixed where the following changes are made to work fine so that users don't get the unnecessary logs again.
by making the following changes
Whenever a user joins a meeting as a user/guest then we will ignore the 403 forbidden error (unnecessary logs) but this does not happen with the verified user. so for that, I used the people API to fetch the user details in this I found that the user is a type of "appuser" so based on this I modified the function "fetchUserPreferredWebexSite" whenever the Guest is joining into the meeting we won't call the "meetingprefernces API" and this will ignore the unnecessary logs as well as in vice versa, it will call the "meetingprefernces API" whenever verified user is trying to join the meeting.
master.branch.403.issue.recording.mp4
Change Type
The following scenarios were tested
Tested by using the guest token ------> works fine as expected (shouldn't log the unnecessary logs (403))
Tested by using the verified Access token ---------> works fine as expected
"Refer to the screen recording"
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.