Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update internal-media-core with conditional device permissions fix #3862

Merged

Conversation

antsukanova
Copy link
Contributor

@antsukanova antsukanova commented Sep 26, 2024

COMPLETES # SPARK-563488

This pull request addresses

This PR contains webrtc-core improvements to the device management functionality for conditional device permissions.

by making the following changes

Changes were made for webrtc-core (PR: webex/webrtc-core#86).
This my PR just upgrades media-core version with these changes.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@antsukanova antsukanova marked this pull request as ready for review September 26, 2024 12:43
@antsukanova antsukanova requested review from a team as code owners September 26, 2024 12:43
@antsukanova antsukanova self-assigned this Sep 26, 2024
@antsukanova antsukanova added the validated If the pull request is validated for automation. label Sep 26, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3862.d3m3l2kee0btzx.amplifyapp.com

@sreenara sreenara enabled auto-merge (squash) September 27, 2024 04:52
@sreenara sreenara merged commit 19c6bf5 into webex:next Sep 27, 2024
11 checks passed
@antsukanova antsukanova deleted the antsukan/conditionally-add-device-permissions branch September 27, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants