-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-cc): set agent status implementation #3970
Conversation
* feat(cc-sdk): ported-code-for-health-check * feat(cc-sdk): fixed-broken-tests * feat(cc-sdk): fixed-blob-issue * feat(cc-sdk): merged-with-ravi-pr * feat(cc-sdk): re-added-cc-code * feat(cc-sdk): added-logger-proxy * feat(cc-sdk): added-config-values * feat(cc-sdk): added-connection-instance * feat(cc-sdk): added-event-listeners-instead-of-signals * feat(cc-sdk): fixed-broken-tests * feat(cc-sdk): fixed-test-coverage
feat(cc): getBuddyAgents implementation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Addressed all the comments from this PR and tested the functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We need to check and ensure the test coverage is present.
COMPLETES #<SPARK-558614>
This pull request addresses
The user should be able to set Agent Status.
API:- https://api.wxcc-us1.cisco.com/v1/agents/session/state
Description:
The user should be able to set Agent Status by making a PUT request to the above API
by making the following changes
Change Type
The following scenarios were tested
I have tested my changes through the CC samples app using the UI changes that I have add. I have tested the Post with valid and invalid request.
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.