-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/practice session - start/stop control API and displayhint #4008
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
06be5d0
feat(ps): add start ps API and displayhint
mickelr 72647b2
feat(ps): add ut
mickelr 2cf86e6
Merge branch 'next' of https://github.com/mickelr/webex-js-sdk into f…
mickelr 561ce54
Merge branch 'next' of https://github.com/mickelr/webex-js-sdk into f…
mickelr 609ae79
feat(ps): updatePracticeSessionStatus
mickelr 8af552d
feat(ps): add ut
mickelr 4a6ba01
Merge branch 'next' into feat/practice_session
mickelr 38c7b86
feat(ps): add roles for invite API
mickelr 17e81d9
Merge branch 'next' of https://github.com/mickelr/webex-js-sdk into f…
mickelr 1380147
Merge remote-tracking branch 'origin/feat/practice_session' into feat…
mickelr 025b823
feat(ps): add ut for invite api
mickelr ae90865
Merge branch 'next' into feat/practice_session
mickelr ca52181
Merge branch 'next' of https://github.com/mickelr/webex-js-sdk into f…
mickelr b79fa7f
Merge branch 'next' of https://github.com/mickelr/webex-js-sdk into f…
mickelr f4300c5
Merge remote-tracking branch 'origin/feat/practice_session' into feat…
mickelr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -262,5 +262,100 @@ describe('plugin-meetings', () => { | |
testParams(false); | ||
}); | ||
}); | ||
|
||
describe('#getAddMemberBody', () => { | ||
it('returns the correct body with email address and roles', () => { | ||
const options = { | ||
invitee: { | ||
emailAddress: '[email protected]', | ||
roles: ['role1', 'role2'], | ||
}, | ||
alertIfActive: true, | ||
}; | ||
|
||
assert.deepEqual(MembersUtil.getAddMemberBody(options), { | ||
invitees: [ | ||
{ | ||
address: '[email protected]', | ||
roles: ['role1', 'role2'], | ||
}, | ||
], | ||
alertIfActive: true, | ||
}); | ||
}); | ||
|
||
it('returns the correct body with phone number and no roles', () => { | ||
const options = { | ||
invitee: { | ||
phoneNumber: '1234567890', | ||
}, | ||
alertIfActive: false, | ||
}; | ||
|
||
assert.deepEqual(MembersUtil.getAddMemberBody(options), { | ||
invitees: [ | ||
{ | ||
address: '1234567890', | ||
}, | ||
], | ||
alertIfActive: false, | ||
}); | ||
}); | ||
|
||
it('returns the correct body with fallback to email', () => { | ||
const options = { | ||
invitee: { | ||
email: '[email protected]', | ||
}, | ||
alertIfActive: true, | ||
}; | ||
|
||
assert.deepEqual(MembersUtil.getAddMemberBody(options), { | ||
invitees: [ | ||
{ | ||
address: '[email protected]', | ||
}, | ||
], | ||
alertIfActive: true, | ||
}); | ||
}); | ||
|
||
it('handles missing `alertIfActive` gracefully', () => { | ||
const options = { | ||
invitee: { | ||
emailAddress: '[email protected]', | ||
roles: ['role1'], | ||
}, | ||
}; | ||
|
||
assert.deepEqual(MembersUtil.getAddMemberBody(options), { | ||
invitees: [ | ||
{ | ||
address: '[email protected]', | ||
roles: ['role1'], | ||
}, | ||
], | ||
alertIfActive: undefined, | ||
}); | ||
}); | ||
|
||
it('ignores roles if not provided', () => { | ||
const options = { | ||
invitee: { | ||
emailAddress: '[email protected]', | ||
}, | ||
alertIfActive: false, | ||
}; | ||
|
||
assert.deepEqual(MembersUtil.getAddMemberBody(options), { | ||
invitees: [ | ||
{ | ||
address: '[email protected]', | ||
}, | ||
], | ||
alertIfActive: false, | ||
}); | ||
}); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: can you point me to where we are using this method, I was unable to find it