feat(plugin-cc): added-call-control #4015

adhmenon · 2024-12-03T13:35:24Z

COMPLETES #< SPARK-562170 (Ticket with Logs Attached>

COMPLETES #< SPARK-562180>

COMPLETES #< SPARK-569541>

COMPLETES #< SPARK-562179>

This pull request addresses

Introduction of call control actions such as hold, resume, end & wrapup call.
Addition of buttons for the above in the sample app.
It is currently based against - feat(plugin-cc): implementation of tasks in agent #4016
Will migrate it once the above PR is merged.

by making the following changes

In the Task class, we call the respective APIs for hold, resume, end and wrapup.
Added the required UI in sample app and made changes to incorporate them.
Unit tested thoroughly

Vidcast - https://app.vidcast.io/share/c2b25b2c-d316-4e41-bbcd-26cced6bc863

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

Tested all flows including registration, login and logout to ensure we are getting the call and call controls are working
Tested with reloading the webpage and checking if relogin with call control was working
Tested by switching of network, waiting for web socket reconnect and then checking if call control functionality was working
Tested by ending call on external user end and checking for wrapup enable
Tested with AGENT_EXTENSION
Agent_DN testing call control

I certified that

I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

coderabbitai · 2024-12-03T13:35:31Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

adhmenon · 2024-12-03T13:37:03Z

packages/@webex/plugin-cc/src/services/core/WebSocket/connection-service.ts

@@ -53,7 +53,7 @@ export class ConnectionService extends EventEmitter {
      isKeepAlive: this.isKeepAlive,
    };
    this.webSocketManager.handleConnectionLost(event);
-    LoggerProxy.log(`Dispatching connection lost event`, {
+    LoggerProxy.log(`Dispatching connection event`, {


This log was misleading, hence I modified it.

adhmenon · 2024-12-03T13:38:02Z

packages/@webex/plugin-cc/src/services/task/index.ts

@@ -86,5 +86,92 @@ export default class Task implements ITask {
    }
  }

-  // TODO: Hold/resume, recording pause/resume, consult and transfer public methods to be implemented here
+  /**
+   * This is used to hold the task.


Have added comments, documentation and methods for each call control. Note that the promise accept/reject is handled in aqm-reqs and we supply the events in the contacts.ts of the task folder (as done in Priya's PR). Everything works smoothly.

adhmenon · 2024-12-03T13:40:36Z

Note - Currently I have set the destination as Priya's PR branch, will change once her PR goes in. Need to wait for one unit test fix on her PR also.

docs/samples/contact-center/app.js

adhmenon · 2024-12-04T11:55:46Z

Added new dropdown for wrapup in call control as per Ravi's advice. Made a new vidcast and attached. Tested all other flows as well and everything is working fine.

….com/Kesari3008/webex-js-sdk into dev/adhmenon-SPARK-562170

Kesari3008

Minor comments, more focus is on covering the test scnearios mentioned

packages/@webex/plugin-cc/src/services/core/aqm-reqs.ts

docs/samples/contact-center/index.html

packages/@webex/plugin-cc/src/services/core/websocket/connection-service.ts

packages/@webex/plugin-cc/src/services/task/index.ts

packages/@webex/plugin-cc/test/unit/spec/services/task/index.ts

docs/samples/contact-center/app.js

adhmenon · 2024-12-06T06:34:22Z

packages/@webex/plugin-cc/src/services/task/index.ts

+   * task.pauseRecording().then(()=>{}).catch(()=>{});
+   * ```
+   */
+  public async pauseRecording(): Promise<TaskResponse> {


Added pause and resume, tested it out on the updated vidcast.

adhmenon · 2024-12-06T06:35:20Z

packages/@webex/plugin-cc/src/services/task/TaskManager.ts

+              this.webCallingService.unregisterCallListeners();
+            }
+            break;
+          case CC_EVENTS.AGENT_WRAPUP:


Need this in case user on other end drops off... there is an issue with the reading of events.
Will sync and look into this issue.

….com/Kesari3008/webex-js-sdk into dev/adhmenon-SPARK-562170

…th multiple login/logout

….com/Kesari3008/webex-js-sdk into dev/adhmenon-SPARK-562170

Kesari3008

Minor comments

packages/@webex/plugin-cc/src/services/task/index.ts

packages/@webex/plugin-cc/src/services/task/TaskManager.ts

packages/@webex/plugin-cc/test/unit/spec/services/task/TaskManager.ts

….com/Kesari3008/webex-js-sdk into dev/adhmenon-SPARK-562170

…/adhmenon-SPARK-562170

adhmenon · 2024-12-12T04:58:29Z

Merged with main feature branch and tested all cases once again.
Everything is working as usual - Vidcast

Kesari3008 and others added 17 commits November 26, 2024 20:03

feat(plugin-cc): call accept implemented

1122f07

feat(plugin-cc): latest merge

acba03a

feat(plugin-cc): added ut, added sample app changes

39a55a4

feat(plugin-cc): fixes in code

616d973

feat(plugin-cc): manual testing for call answer and decline finished

555289d

feat(plugin-cc): small fixes in sample app

3754f66

feat(plugin-cc): fixed ut

d3809b2

feat(plugin-cc): fixed ut

9b40fde

feat(plugin-cc): ut fix

e756062

feat(plugin-cc): review comments

cfe40f6

feat(plugin-cc): ut fixes

963fa03

feat(plugin-cc): ut fixes

37ec111

feat(plugin-cc): merge conflict

e8dcefd

feat(plugin-cc): review comments thrid round

c9f2e2c

feat(plugin-cc): sample app fixes

2d3b7ee

feat(plugin-cc): test file import fixes

cc99ac8

feat(cc-sdk): added-call-control

4ac05c2

adhmenon requested a review from a team as a code owner December 3, 2024 13:35

adhmenon commented Dec 3, 2024

View reviewed changes

adhmenon added the validated If the pull request is validated for automation. label Dec 3, 2024

adhmenon changed the title ~~feat(cc-sdk): added-call-control~~ feat(plugin-cc): added-call-control Dec 3, 2024

sreenara and others added 3 commits December 4, 2024 02:09

fix(plugin-cc): rename folders

ac450ed

feat(cc-sdk): added-log-changes

8f6563f

feat(cc-sdk): fixed-sample-app-issue

064328f

rsarika approved these changes Dec 4, 2024

View reviewed changes

docs/samples/contact-center/app.js Outdated Show resolved Hide resolved

feat(cc-sdk): added-wrapup-dropdown

8917ab4

Kesari3008 and others added 4 commits December 4, 2024 23:37

fix(plugin-cc): ut added for off listeners

4c6a2bc

feat(plugin-cc): added types and add ut for cc file

fa4c42e

Merge branch 'SPARK-562169-Task-API-Implementation' of https://github…

d65c4fd

….com/Kesari3008/webex-js-sdk into dev/adhmenon-SPARK-562170

feat(cc-sdk): fixed-pipeline-fix

352315f

Kesari3008 requested changes Dec 6, 2024

View reviewed changes

Kesari3008 and others added 2 commits December 6, 2024 10:05

feat(plugin-cc): updated logs

93dc3d0

feat(cc-sdk): added-recording-pause-and-resume

a0d93ca

adhmenon requested a review from Kesari3008 December 6, 2024 06:32

adhmenon commented Dec 6, 2024

View reviewed changes

adhmenon and others added 6 commits December 6, 2024 12:56

feat(cc-sdk): added-task-response-unit-tests

098948e

feat(cc-sdk): added-end-call-edge-case

2f154e3

Merge branch 'SPARK-562169-Task-API-Implementation' of https://github…

1f2cee9

….com/Kesari3008/webex-js-sdk into dev/adhmenon-SPARK-562170

feat(cc-sdk): added-cleanup-on-call-wrapup

daeb3e5

feat(plugin-cc): fixed the issue with incoming call being received wi…

7988048

…th multiple login/logout

Merge branch 'SPARK-562169-Task-API-Implementation' of https://github…

441c992

….com/Kesari3008/webex-js-sdk into dev/adhmenon-SPARK-562170

Kesari3008 reviewed Dec 6, 2024

View reviewed changes

feat(cc-sdk): added-tests-for-edge-cases

05b9ace

adhmenon requested a review from Kesari3008 December 6, 2024 16:06

Kesari3008 and others added 4 commits December 11, 2024 21:13

fix(plugin-cc): review comments

1d7a016

Merge branch 'SPARK-562169-Task-API-Implementation' of https://github…

f058339

….com/Kesari3008/webex-js-sdk into dev/adhmenon-SPARK-562170

fix(plugin-cc): review comments

57f71e1

Merge branch 'SPARK-562169-Task-API-Implementation' of https://github…

65cd8fe

….com/Kesari3008/webex-js-sdk into dev/adhmenon-SPARK-562170

Kesari3008 approved these changes Dec 11, 2024

View reviewed changes

adhmenon added 2 commits December 12, 2024 09:51

Merge branch 'wxcc' of https://github.com/webex/webex-js-sdk into dev…

83c4345

…/adhmenon-SPARK-562170

feat(wxcc): fixed-merge-conflicts

1f56afa

adhmenon changed the base branch from SPARK-562169-Task-API-Implementation to wxcc December 12, 2024 04:34

adhmenon merged commit 7a04e01 into webex:wxcc Dec 12, 2024
12 checks passed

adhmenon deleted the dev/adhmenon-SPARK-562170 branch December 12, 2024 05:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plugin-cc): added-call-control #4015

feat(plugin-cc): added-call-control #4015

adhmenon commented Dec 3, 2024 •

edited

Loading

coderabbitai bot commented Dec 3, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

adhmenon Dec 3, 2024

adhmenon Dec 3, 2024

adhmenon commented Dec 3, 2024

adhmenon commented Dec 4, 2024

Kesari3008 left a comment

adhmenon Dec 6, 2024

adhmenon Dec 6, 2024

Kesari3008 left a comment

adhmenon commented Dec 12, 2024

feat(plugin-cc): added-call-control #4015

feat(plugin-cc): added-call-control #4015

Conversation

adhmenon commented Dec 3, 2024 • edited Loading

COMPLETES #< SPARK-562170 (Ticket with Logs Attached>

COMPLETES #< SPARK-562180>

COMPLETES #< SPARK-569541>

COMPLETES #< SPARK-562179>

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

I certified that

coderabbitai bot commented Dec 3, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

adhmenon Dec 3, 2024

Choose a reason for hiding this comment

adhmenon Dec 3, 2024

Choose a reason for hiding this comment

adhmenon commented Dec 3, 2024

adhmenon commented Dec 4, 2024

Kesari3008 left a comment

Choose a reason for hiding this comment

adhmenon Dec 6, 2024

Choose a reason for hiding this comment

adhmenon Dec 6, 2024

Choose a reason for hiding this comment

Kesari3008 left a comment

Choose a reason for hiding this comment

adhmenon commented Dec 12, 2024

adhmenon commented Dec 3, 2024 •

edited

Loading

coderabbitai bot commented Dec 3, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)