feat: expose separate events for ice and dtls connecting state #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-wasniowski
requested review from
szotrabh,
bbaldino,
marcin-bazyl and
brycetham
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements exposing two events instead of one to divide states for
Ice Connecting Phase, andDTLS Connectin Phase.The purpose is to enable easier finding out at which part in JS-SDK we are failing to connect to our backend.
Currently evaluation is done in JS-SDK, but it uses internal objects of webrtc-core, which should not be a desired way.
My and Marcin proposal is to separate events for ICE and DTLS phases. However, I guess we could also expose some getter for
ice connection state.