Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update typescript version #81

Merged
merged 2 commits into from
Jul 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"semantic-release": "^19.0.2",
"ts-jest": "^27.0.5",
"ts-loader": "^9.2.3",
"typescript": "^4.4.3",
"typescript": "^5.5.2",
"yarn": "^1.22.18"
},
"scripts": {
Expand Down
2 changes: 0 additions & 2 deletions src/device/device-management.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ describe('Device Management', () => {
noiseSuppression: false,
sampleRate: 48000,
sampleSize: 16,
suppressLocalAudioPlayback: false,
});
expect(media.getUserMedia).toHaveBeenCalledWith({
audio: {
Expand All @@ -60,7 +59,6 @@ describe('Device Management', () => {
noiseSuppression: false,
sampleRate: 48000,
sampleSize: 16,
suppressLocalAudioPlayback: false,
},
});
});
Expand Down
1 change: 0 additions & 1 deletion src/device/device-management.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export type AudioDeviceConstraints = Pick<
| 'noiseSuppression'
| 'sampleRate'
| 'sampleSize'
| 'suppressLocalAudioPlayback'
>;

export type VideoDeviceConstraints = Pick<
Expand Down
2 changes: 1 addition & 1 deletion src/media/local-audio-stream.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { LocalStream, LocalStreamEventNames } from './local-stream';
// These are the audio constraints that can be applied via applyConstraints.
export type AppliableAudioConstraints = Pick<
MediaTrackConstraints,
'autoGainControl' | 'echoCancellation' | 'noiseSuppression' | 'suppressLocalAudioPlayback'
'autoGainControl' | 'echoCancellation' | 'noiseSuppression'
>;

/**
Expand Down
1 change: 1 addition & 0 deletions src/mocks/create-permission-status.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ export const createPermissionStatus = (state: PermissionState): PermissionStatus
addEventListener: () => {},
removeEventListener: () => {},
dispatchEvent: (event: Event): boolean => true,
name: '',
});
1 change: 0 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
// "noUnusedLocals": true /* Report errors on unused locals. */,
// "noUnusedParameters": true /* Report errors on unused parameters. */,
"noImplicitReturns": true /* Report error when not all code paths in function return a value. */,
"suppressImplicitAnyIndexErrors": true /* Suppresses errors about implicit anys when indexing into objects. */,
// "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
// "noUncheckedIndexedAccess": true, /* Include 'undefined' in index signature results */
// "noImplicitOverride": true, /* Ensure overriding members in derived classes are marked with an 'override' modifier. */
Expand Down
7 changes: 6 additions & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -11029,7 +11029,12 @@ typedarray-to-buffer@^3.1.5:
dependencies:
is-typedarray "^1.0.0"

typescript@^4.4.3, typescript@~4.8.4:
[email protected]:
version "5.5.2"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.5.2.tgz#c26f023cb0054e657ce04f72583ea2d85f8d0507"
integrity sha512-NcRtPEOsPFFWjobJEtfihkLCZCXZt/os3zf8nTxjVH3RvTSxjrCamJpbExGvYOF+tFHc3pA65qpdwPbzjohhew==

typescript@~4.8.4:
version "4.8.4"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.8.4.tgz#c464abca159669597be5f96b8943500b238e60e6"
integrity sha512-QCh+85mCy+h0IGff8r5XWzOVSbBO+KfeYrMQh7NJ58QujwcE22u+NUSmUxqF+un70P9GXKxa2HCNiTTMJknyjQ==
Expand Down
Loading