Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webex): upgrading webex to new-version #235

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

Parimala032
Copy link
Contributor

@Parimala032 Parimala032 commented Oct 22, 2024

Completes SPARK-552246

This pull request addresses

Upgrading the webex to newer-version which is 2.x version and the sdk-component-adapter to the newer-version as well which is 1.112.x version

  • This Upgrading webex to newer-version is because of the fix that was made in SDK that needs to be in widgets

  • So the fix is about the user trying to joinmeeting by entering the name according to their wish but unfortunately, the user entered name was not reflected on the remote side of the meeting rather it printed the system default name so SDK fix will give the solution in the widgets that is why the webex is needed to upgrade in the widgets to reflect the changes that made in SDK

  • Also upgrading the sdk-component-adapter to new version in widgets because whatever the fix does on the SDK side that version has upgraded in the sdk-component-adapter so the newer-version of sdk-component-adapter is upgrading in the widgets as well

The following scenarios were tested

  • After upgrading the version of webex and sdk-component-adapter in widgets I tested this to see whether the fix has been successful or not and it got success please do see the screen recording for more clarity
Testing.PR.webex.upgraded.in.widgets.mp4

Summary by CodeRabbit

  • Chores
    • Updated dependencies for improved performance and stability, including @webex/sdk-component-adapter and webex.

@Kesari3008
Copy link
Contributor

Kesari3008 commented Oct 25, 2024

@Parimala032 Please add test details and screen recordings or screenshots in the PR description. Also mention the Jira number and why this change was needed

@sreenara sreenara merged commit 248aa87 into webex:master Oct 29, 2024
1 check passed
@sreenara
Copy link
Contributor

🎉 This PR is included in version 1.27.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

coderabbitai bot commented Oct 29, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The package.json file for the @webex/widgets project has been updated to reflect changes in dependency versions. Specifically, the version of @webex/sdk-component-adapter has been increased from 1.112.11 to 1.112.12, and the version of webex has been updated from 2.60.2 to 2.60.4 in both the dependencies and peerDependencies sections. No other modifications were made to scripts or configurations.

Changes

File Change Summary
package.json Updated dependencies: @webex/sdk-component-adapter from 1.112.11 to 1.112.12; webex from 2.60.2 to 2.60.4 in both dependencies and peerDependencies.

Poem

In the garden of code, a change took flight,
Versions updated, everything feels right.
With adapters and webex, we hop along,
Each little update makes our project strong!
So here’s to the tweaks, both big and small,
A leap for the widgets, let’s celebrate all! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

mkesavan13 pushed a commit to mkesavan13/widgets that referenced this pull request Oct 29, 2024
## [1.27.5](webex/widgets@v1.27.4...v1.27.5) (2024-10-29)

### Bug Fixes

* **webex:** upgrading webex to new-version ([webex#235](webex#235)) ([248aa87](webex@248aa87))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants