-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webex): upgrading webex to new-version #235
Conversation
@Parimala032 Please add test details and screen recordings or screenshots in the PR description. Also mention the Jira number and why this change was needed |
🎉 This PR is included in version 1.27.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Caution Review failedThe pull request is closed. WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
## [1.27.5](webex/widgets@v1.27.4...v1.27.5) (2024-10-29) ### Bug Fixes * **webex:** upgrading webex to new-version ([webex#235](webex#235)) ([248aa87](webex@248aa87))
Completes SPARK-552246
This pull request addresses
Upgrading the webex to newer-version which is 2.x version and the sdk-component-adapter to the newer-version as well which is 1.112.x version
This Upgrading
webex
to newer-version is because of the fix that was made in SDK that needs to be in widgetsSo the fix is about the user trying to
joinmeeting
by entering the name according to their wish but unfortunately, the user entered name was not reflected on the remote side of the meeting rather it printed the system default name so SDK fix will give the solution in the widgets that is why thewebex
is needed to upgrade in the widgets to reflect the changes that made in SDKAlso upgrading the
sdk-component-adapter
to new version in widgets because whatever the fix does on the SDK side that version has upgraded in thesdk-component-adapter
so the newer-version ofsdk-component-adapter
is upgrading in thewidgets
as wellThe following scenarios were tested
webex
andsdk-component-adapter
in widgets I tested this to see whether the fix has been successful or not and it got success please do see the screen recording for more clarityTesting.PR.webex.upgraded.in.widgets.mp4
Summary by CodeRabbit
@webex/sdk-component-adapter
andwebex
.