Merge pull request #677 from alexzurbonsen/allow-manifests-with-jsonc

package.json

@@ -38,6 +38,7 @@
     "@types/chrome": "^0.0.268",
     "@types/firefox-webext-browser": "^120.0.3",
     "ajv": "^6.12.6",
+    "jsonc-parser": "^3.3.1",
     "mustache": "^4.2.0",
     "webpack-sources": "^3.2.3",
     "ws": "^8.16.0"

src/plugin/index.ts

@@ -5,6 +5,7 @@ import webpack, { Compiler, Compilation, Stats } from "webpack";
 import Mustache from "mustache";
 import { constants, readFileSync } from "fs";
 import { access } from "fs/promises";
+import { stripComments } from "jsonc-parser";
 import vendors from "./vendors.json";
 import {
   Manifest,
@@ -164,7 +165,7 @@ class WebextensionPlugin {
     const manifestBuffer = readFileSync(manifestPath, {
       encoding: "utf8",
     });
-    const manifest = JSON.parse(manifestBuffer);
+    const manifest = JSON.parse(stripComments(manifestBuffer));
     const serviceWorker = manifest?.background?.service_worker ?? null;
 
     if (
@@ -374,11 +375,13 @@ class WebextensionPlugin {
         compilation.options.context,
         this.manifestNameDefault
       );
-      const manifestBuffer = await this.readFile(manifestPath);
+      const manifestBuffer = readFileSync(manifestPath, {
+        encoding: "utf8",
+      });
       let manifest: Manifest;
       // Convert to JSON
       try {
-        manifest = JSON.parse(manifestBuffer);
+        manifest = JSON.parse(stripComments(manifestBuffer));
       } catch (error) {
         throw new Error(`Could not parse ${this.manifestNameDefault}`);
       }