Add option to export library as webgmex #333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeijer
changed the title
kecso
requested changes
Jul 19, 2024
| .then(function (rawJson) { | ||
| if (parameters.libraryName) { | ||
| // We need to adjust this when the exportee was a library. | ||
| delete rawJson.kind; // This is lost at this point. |
There was a problem hiding this comment.
i believe i know where this come from, but is this really the good behavior?
shouldn't we enhance the library info with the kind to begin with?
| .finally(restoreProcessFunctions) | ||
| .nodeify(done); | ||
| }); | ||
|
|
||
| it('should fail to exportProjectToFile when branchName does not exist.', function (done) { | ||
| var worker = getSimpleWorker(); | ||
|
|
There was a problem hiding this comment.
any chance to add a test that would use the exported libary and run some traversal to see if everything goes well during the read of the nodes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.