refactor: remove commodo #4436
Merged
refactor: remove commodo #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunozoric
requested review from
Pavel910 and
adrians5j
and removed request for
Pavel910
Pavel910
approved these changes
Dec 16, 2024
brunozoric
force-pushed
the
bruno/refactor/remove-commodo
branch
from
d14e510 to
d32914d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR replaces commodo validation with Zod in all packages we used commodo.
How Has This Been Tested?
Jest, Cypress and team testing effort.
Packages changed
TODO
Create a simple method to merge validation result data with original data. Not a deep merge.
Basically, check for value in validation being undefined and then skip assigning it.