Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Wish event thursday' to other events on company interest page #5331

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

magnusbrecke
Copy link
Contributor

Description

Added an option under other events on company interest page that got requested by bedkom:
Skjermbilde 2025-02-10 kl  10 34 47

But not sure if this little change is all that is needed?

Result

If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.
Before After
Before Image After Image

Testing

  • I have thoroughly tested my changes.

Resolves ABA-1271

@magnusbrecke magnusbrecke added the help-wanted Pull requests that want help in the form of contributions label Feb 10, 2025
@magnusbrecke magnusbrecke self-assigned this Feb 10, 2025
Copy link

linear bot commented Feb 10, 2025

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 9:46am

@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 10, 2025
Comment on lines +136 to +139
thursday_event: {
norwegian: 'Ønsker arrangement torsdag',
english: 'Wish event thursday',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this field be included in the request body when submitting the form? Nevertheless, you'll need to update the db model in the backend

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so looking at the code in CompanyInterestPage. I'll look into the backend

Copy link
Contributor

@ShaileshS1702 ShaileshS1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magnusbrecke magnusbrecke merged commit 6b93d27 into master Feb 12, 2025
8 checks passed
@magnusbrecke magnusbrecke deleted the other-offer-on-interestschema branch February 12, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted Pull requests that want help in the form of contributions review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants