Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Suspense and lazy #35

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Add support for Suspense and lazy #35

merged 2 commits into from
Jan 30, 2025
+90 −10

Conversation

eikhr
Copy link
Member

@eikhr eikhr commented Jan 30, 2025

Needed for lazy loaded pages in the lego-webapp vite migration.

How does it work? Who knows... but the tests are passing and it works for me in the lego-webapp vite branch

ivarnakken
ivarnakken approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit::shipit::shipit::shipit: great shit

@eikhr eikhr merged commit 9d27680 into master Jan 30, 2025
1 check passed
@eikhr eikhr deleted the support-lazy branch January 30, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarnakken ivarnakken ivarnakken approved these changes

@Bestem0r Bestem0r Awaiting requested review from Bestem0r

@itsisak itsisak Awaiting requested review from itsisak

@danielyanghansen danielyanghansen Awaiting requested review from danielyanghansen

@ollfkaih ollfkaih Awaiting requested review from ollfkaih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eikhr @ivarnakken