Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create com.pirate.refresh.yml #122

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LucifersCircle
Copy link

added automatic dev token refresh app. This queries against a server located at lg.pirate.vodka, which has an open source infrastructure.

  • side note, I'm pretty sure I did my manifest wrong, if so please let me know and I'll change it in the app to better reflect other linked manifests, although I'm not totally sure where they got all the entries inside their manifests.

https://github.com/LucifersCircle/WebOS-Token-Refresh-App

added automatic dev token refresh app. This queries against a server located at lg.pirate.vodka, which has an open source infrastructure.
@mariotaku
Copy link
Member

Hello! This tool can be used to generate manifest properly.

generated manifest with webosbrew-gen-manifest and updated here to reflect
@LucifersCircle
Copy link
Author

@mariotaku I believe I have fixed the manifest! May have gotten source url wrong but I am mostly sure it's right. I linked to the ipk there, if I should link to the directory or root of the repo instead please let me know!

Copy link

github-actions bot commented Dec 14, 2024

Check Results for com.pirate.refresh.yml:

Package Metadata

✅ Check passed.

Compatibility Check

App com.pirate.refresh

Skip because this component is not native

All OK

Service com.pirate.refresh.service

Skip because this component is not native

All OK

packages/com.pirate.refresh.yml Outdated Show resolved Hide resolved
@@ -0,0 +1,20 @@
title: Auto Dev Token Refresh
iconUri: https://github.com/LucifersCircle/WebOS-Token-Refresh-App/blob/main/src/app/icon.png?raw=true
manifestUrl: https://raw.githubusercontent.com/LucifersCircle/WebOS-Token-Refresh-App/refs/heads/main/manifest.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same thing applies to the manifest, but since it changes through versions, we could use this.

I would suggest using releases instead, please let me know if you need help creating that!

@mariotaku
Copy link
Member

Hello! I have some minor suggestions for you.

Also for the ipkUrl part, it's solved related to the manifest, so I think it should be something like src/com.pirate.refresh_1.0.0_all.ipk

@LucifersCircle
Copy link
Author

LucifersCircle commented Dec 14, 2024

@mariotaku I am honestly unfamiliar with github, the most I've used it for in the past is keeping some personal projects backed-up somewhere haha. One example, how did you get the url for the image? Did you have to manually change it, or is there a way to copy the one you edited?! I would love any help you could give to make this good to go! My baby is waking up so I'll have to come back in a while.

Edit: would you also clarify this please?! I would like help with that haha.

I would suggest using releases instead

also, manifest has been updated
image

Edit 2: after thinking about it for a while, by releases did you perhaps mean building with a workflow and publishing the artifact to the releases section in the github repo, then linking to the releases page?! If thats the case I can likely figure that out!

Edit 3: I made a workflow that builds the app and uploads the artifact to the releases page, where should I put the url to the releases page?! Source URL? https://github.com/LucifersCircle/WebOS-Token-Refresh-App/releases/

@mariotaku
Copy link
Member

@LucifersCircle Very awesome! If you could generate the manifest, then upload along with the IPK to the releases, then it should work too.

@LucifersCircle
Copy link
Author

LucifersCircle commented Dec 15, 2024

@mariotaku im not quite sure how I'd do that, would I need to put the binary for manifest-gen in my project directory? And the fw too? I'll think on it for a while maybe I can put them in a temp dir with the workflow itself.

@mariotaku
Copy link
Member

@LucifersCircle You could generate the manifest in the workflow, and upload it as a release.

If you don't have too much to release, generating & uploading manually would do, too.

@LucifersCircle
Copy link
Author

@mariotaku As it is right now, I don't plan on any future app updates unless functionality gets broken. It should be ok to release as is. I will still work on generating the manifest automatically for fun when I have free time.

use releases for manifest, most up to date manifest can always be found with releases /latest endpoint
@LucifersCircle
Copy link
Author

@mariotaku Finally finished getting it all built and the manifest generated using the workflow! I believe everything should be in its intended and final spot now!
https://github.com/LucifersCircle/WebOS-Token-Refresh-App/releases
https://github.com/LucifersCircle/WebOS-Token-Refresh-App/releases/latest/download/manifest.json
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants