Add events for config value changes #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
throwaway96
force-pushed
the
config-events-20240328
branch
from
d9c7207 to
0d846a9
Compare
All other functions exported by config.js have a "config" prefix. There is also currently no need to export configOptions.
throwaway96
force-pushed
the
config-events-20240328
branch
from
0d846a9 to
a8ed86b
Compare
|
Why are you using From MDN: |
|
The |
mariotaku
approved these changes
Mar 29, 2024
throwaway96
added a commit
that referenced
this pull request
Mar 29, 2024
Also add a newline I forgot last time.
fire332
pushed a commit
to fire332/youtube-webos
that referenced
this pull request
Mar 31, 2024
Also add a newline I forgot last time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to listen for changes to a config value with
configAddChangeListener(key, callback)(plus of courseconfigRemoveChangeListener()).Using this functionality, the options panel UI now updates automatically when settings are modified with
configWrite().I'm not sure using
DocumentFragments is the best way (or even a good way) to do this. It does seem to work, though.