Add option to hide youtube logo #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Informatic
approved these changes
Dec 19, 2022
Hi, @Informatic! There’s not much development happening lately in this repo. Maybe it’s worth releasing a small release with this feature? |
|
Any news on this? |
|
Has this been tested? If the 0.4.0 stuff (all changes to |
|
In case anyone is interested, me and the creator of youtube-webos-cobalt modified the code a while ago to work without the DOMNodeInserted event. I can open a pull request if needed. |
|
I'd appreciate a PR for that version, and then this one can be closed. |
|
Done! Here it is: #135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
My LG C7 is starting to have some burning, because of this (stupid) YouTube logo in pure red, so I've searched a solution.
I've found this ticket on the parent repository : FriedChickenButt#30
I followed the instructions and basically copy/paste the code.
Thanks @ksala and @Informatic :)
I also added the checkbox in the option modal, and tagged the version as 0.4.0
I've tested the feature and it works.
When you check/uncheck, the logo don't instanly appear/disappear, you have for example to go to the left menu for the change to apply. That's all :)
Hope it will helps other.
Regards.