Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chunk minification #117

Merged
merged 2 commits into from
Feb 14, 2020
Merged

Fix chunk minification #117

merged 2 commits into from
Feb 14, 2020

Conversation

DreierF
Copy link
Contributor

@DreierF DreierF commented Jan 11, 2020

Hi,

This PR fixes the issue described #52 (comment).
Chunks were not correctly processed in standard mode, because the field that holds the chunk's parents was used inconsistently. The first entry contained a parentChunkNames and the followup entries contained parentNames instead. This broke the destructuring assignment and led to parentChunkNames being undefined all the time.

@jsf-clabot
Copy link

jsf-clabot commented Jan 11, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@DreierF DreierF force-pushed the fix_chunk_minification branch from 2b1ae34 to 1678c0c Compare January 11, 2020 11:26
@ChadKillingsworth
Copy link
Member

Thanks - looks great.

@ChadKillingsworth ChadKillingsworth merged commit de1c121 into webpack-contrib:master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DreierF @jsf-clabot @ChadKillingsworth