docs(README): add example #45
Conversation
|
Tiberiu Corbu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
|
Does the example look OK ? Should I improve it somehow ? |
|
@tiberiucorbu please accept CLA |
| @@ -49,6 +52,10 @@ module.exports = { | |||
| import exec from 'script-loader!./script.js'; | |||
| ``` | |||
|
|
|||
| ### Example | |||
There was a problem hiding this comment.
<h2 align="center">Examples</h2>
| @@ -49,6 +52,10 @@ module.exports = { | |||
| import exec from 'script-loader!./script.js'; | |||
| ``` | |||
|
|
|||
| ### Example | |||
|
|
|||
| Take a look at the example provided in the [./example](example) folder | |||
There was a problem hiding this comment.
Please add a small example(s) directly to the README here
| @@ -0,0 +1,37 @@ | |||
| # Script loader example | |||
There was a problem hiding this comment.
I'm sry, but we try to avoid adding (new) example/ to repos directly as they tend to be getting outdated and nobody is normally willing to maintain them. Please add a small example to the README instead (as mentiond above) and remove the example/ folder
michael-ciniawsky
added
pr_action: Rework
severity: 4 (inconvenient)
status: Pending
and removed
pr_action: Review
labels
|
@tiberiucorbu Please sign the CLA. Otherwise I'm going to close this PR within the next 48-72 hours due to the missing CLA signment |
|
I'm closing this due to inactivity for now, feel free to reopen if the comments are addressed and the CLA is signed. Thx |
Regarding #44 here is my attempt to improve the doc and provide an useful example