Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of injectHot and injectClient on specific chunks #2995

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

paztis
Copy link

@paztis paztis commented Feb 6, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

In case of application with multiple iframes, only the top level frame has to listen socket for refresh
This PR add the support of chunk target in the injectClient and injectHot options. You are able to limit the client injection only in specific chunks

Resolving of #2969

Breaking Changes

none

Additional Info

@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

❗ No coverage uploaded for pull request base (v3@5cb545f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             v3    #2995   +/-   ##
=====================================
  Coverage      ?   93.51%           
=====================================
  Files         ?       34           
  Lines         ?     1342           
  Branches      ?      384           
=====================================
  Hits          ?     1255           
  Misses        ?       85           
  Partials      ?        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cb545f...17e3ccc. Read the comment docs.

@paztis
Copy link
Author

paztis commented Mar 2, 2021

any news ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant