Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing references to package.json #5

Merged

Conversation

petertonysmith94
Copy link
Contributor

Closes #4

You can see this resolution by running the following command in the example from the issue:

sed -i '' 's/"main": "target\/cjs\/index.cjs",/"main": "target\/cjs\/index.cjs",\n  "module": "target\/esm\/index.mjs",\n  "types": "target\/dts\/index.d.ts",/' node_modules/@webpod/ps/package.json

Then running:

pnpm tsc --noEmit

@antongolub
Copy link
Member

antongolub commented Dec 16, 2024

Hey @petertonysmith94,

Could you add a basic test for this issue? Perhaps this should be handled for another packages too.

TypeScript isn't properly resolving the type definitions for @webpod/ps under the current module resolution strategy ('node').

Attach a demo plz

@antongolub
Copy link
Member

Accepted. Thanks.

@antongolub antongolub merged commit 8bcfb02 into webpod:main Dec 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types misconfigured for "moduleResolution" set to "node"
2 participants