fix: relax isTemplateLiteral check for tslib compat

microsoft/tslib#277
webpod · Dec 9, 2024 · 898f0d0 · 898f0d0
1 parent f93fdf4
commit 898f0d0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -87,6 +87,7 @@
     "jsr": "^0.13.2",
     "minimist": "^1.2.8",
     "ts-node": "^10.9.2",
+    "tslib": "^2.8.1",
     "typedoc": "^0.27.2",
     "typescript": "^5.7.2"
   }

diff --git a/src/main/ts/util.ts b/src/main/ts/util.ts
@@ -38,7 +38,7 @@ export const isStringLiteral = (
 ): pieces is TemplateStringsArray =>
   pieces?.length > 0 &&
   pieces.raw?.length === pieces.length &&
-  Object.isFrozen(pieces) &&
+  // Object.isFrozen(pieces) &&
   rest.length + 1 === pieces.length
 
 export const assign = <T, E>(target: T, ...extras: E[]): T =>

diff --git a/src/test/ts/util.test.ts b/src/test/ts/util.test.ts
@@ -1,6 +1,7 @@
 import * as assert from 'node:assert'
 import {describe, it, test} from 'node:test'
 import { assign, isStringLiteral } from '../../main/ts/util.js'
+import tslib from 'tslib'
 
 describe('util', () => {
   it('assign()', () => {
@@ -13,6 +14,7 @@ describe('util', () => {
     assert.ok(isStringLiteral``)
     assert.ok(isStringLiteral`foo`)
     assert.ok(isStringLiteral`foo ${bar}`)
+    assert.ok(isStringLiteral(tslib.__makeTemplateObject(["git pull --tags --force ", " ", ""], ["git pull --tags --force ", " ", ""]), 'foo', 'bar'))
 
     assert.ok(!isStringLiteral(''))
     assert.ok(!isStringLiteral('foo'))