-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collection page list/search endpoint #2354
Open
tw4l
wants to merge
17
commits into
main
Choose a base branch
from
issue-2352-collection-page-list-search
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw4l
changed the title
WIP: Add collection page list/search endpoint
Add collection page list/search endpoint
Jan 30, 2025
ikreymer
reviewed
Feb 4, 2025
We should probably do this for crawls as well, so larger crawls can be replayed easily w/o having to be added to collections.. |
tw4l
force-pushed
the
issue-2352-collection-page-list-search
branch
from
February 4, 2025 22:51
7a75fb2
to
29028e7
Compare
tw4l
force-pushed
the
issue-2352-collection-page-list-search
branch
from
February 5, 2025 20:51
29028e7
to
79972a4
Compare
@ikreymer This is ready for re-review. Changes made:
The only remaining test failure is the unrelated QA failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2353
Adds a new endpoint to list pages in a collection, with filtering available on
url
(exact match),ts
,urlPrefix
,isSeed
, anddepth
, as well as accompanying tests. Additional sort options have been added as well.These same filters and sort options have also been added to the crawl pages endpoint.
Also fixes an issue where
isSeed
wasn't being set in the database when false but only added on serialization, which was preventing filtering from working as expected.