Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring into v2 #22

Merged
merged 16 commits into from
Oct 10, 2024
Merged

refactoring into v2 #22

merged 16 commits into from
Oct 10, 2024

Conversation

webstradev
Copy link
Owner

  • Refactor the code for better maintainability
  • v2 API, with functional options pattern.
  • More idiomatic go decisions and standards.

@webstradev
refactor: Using proper capitalization for constants
c764e57 
Signed-off-by: Erik <[email protected]>
@webstradev
refactor: follow go conventionsn for public methods.
6105f18 
Signed-off-by: Erik <[email protected]>
@webstradev
refactor: Make default constants private.
a91e538 
Signed-off-by: Erik <[email protected]>
@webstradev
chore: Add package comment.
55edd0a 
Signed-off-by: Erik <[email protected]>
@webstradev
refactor: Switch to functional options pattern.
e6c2ada 
Signed-off-by: Erik <[email protected]>
@webstradev
chore: make options private
a2cff9d 
Signed-off-by: Erik <[email protected]>
@webstradev
refactor: Improve package comment
fb2c850 
Signed-off-by: Erik <[email protected]>
@webstradev
refactor: Expand option customizers.
56c2494 
Signed-off-by: Erik <[email protected]>
@webstradev
refactor: Move completely to functional options + formatting.
b106849 
Signed-off-by: Erik <[email protected]>
@webstradev
refactor: Move pagination package into pkg/
a318f02 
Signed-off-by: Erik <[email protected]>
@webstradev
fix: ci test package reference
7a427be 
Signed-off-by: Erik <[email protected]>
@webstradev
chore: Please godot linter.
255cb2b 
Signed-off-by: Erik <[email protected]>
@webstradev
refactor: Make number options an integer.
ad2dee4 
Signed-off-by: Erik <[email protected]>
@webstradev
refactor: Introduce paginator struct for cleaner code.
ed086e9 
Signed-off-by: Erik <[email protected]>
@webstradev webstradev self-assigned this Oct 10, 2024
@webstradev webstradev added the enhancement New feature or request label Oct 10, 2024
@webstradev webstradev merged commit cbd01db into master Oct 10, 2024
5 checks passed
@webstradev webstradev deleted the refactoring branch October 10, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@webstradev webstradev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@webstradev