Fix: Error messages now respect custom option names and values.

[jmetrikat]

Previously, error messages in validatePage and validatePageSize didn’t make use of the names and values from custom options: opts.PageText, opts.SizeText, p.opts.MinPageSize and p.opts.MaxPageSize.

Now, they correctly substitute those values, and I’ve expanded the test cases to ensure proper behavior in error messages.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c7283b2) to head (803f032).

Additional details and impacted files

@@            Coverage Diff            @@
##            master       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           87        87           
=========================================
  Hits            87        87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[webstradev]

Thanks for this, good suggestion, the only thing I don't love is directly checking errors strings rather than comparing them with errors is /errors as, but maybe in this case it's okay

[webstradev]

@jmetrikat I think the idea is good, but I would rather see it implemented with specific errors, that we than test for instead of just relying on string matching. Is that something you are willing to give a go? Otherwise I can take it over if you don't have the bandwidth.

Would be something like this:

And then there can just be separate tests for those validator functions to see if they error in the correct cases and with the correct values.

Seems a cleaner to me then testing a string in the json response.

[jmetrikat]

@webstradev looks good! considered a similar approach, but hesitated due to the larger changes needed. i don't have the capacity currently, so feel free to take it over!