More work on pecl-memcache #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Zaffy
commented
Oct 8, 2020
Zaffy
commented
- added test for "Memcache session handling, zend_mm_heap corrupted" on bugs.php.net #65 and fixed the leak
- added support for reflection Add ReflectionParameter param information for functions and methods? #64
- added test for Fix crash when serialization fails #53
- fixed failing tests including session redundancy weird behaviour when reopening session during request #46 and session_start(): Failed to read session data: memcache using php7.2 #57
- fixed underlying issue in Test in Symfony's HttpFoundation failing with websupport-sk/pecl-memcache under PHP 7 #7
- fixed binary protocol support
- fixed found memory leaks
- master is now a unified branch for both php7 and php8 sources (the commits spam is necessary to retain history)
…s extra option for an extension)
Made consistent hashing implementation failover compatible with branch
Fixed incompatibility with standard hash strategy in previous versions
Prepare for release 2.2.1
… (PECL bug #12555) Prepare for release 2.2.2
Need be reviewed by the author later
…so application code can use
applying patch for php bug 73539
I think that these might have uninitialized bytes when a data type larger than zend_bool is used for the ini setting, if the module globals are set from malloc? (Not 100% sure if the entire structure isn't set to 0 before being used) Related to #56
Use zend_bool for ini bool settings
Conflicts: php8/memcache.c
This will allow us to have one unified branch that will compile under different versions of php.
- added / updated arginfos - fix functions returning NULL instead of advertised return type, For example, when memcached returned error on "delete", function returned null instead of false - added tests for both php8 and 7
thesource93
reviewed
Oct 8, 2020
| ZEND_ARG_TYPE_INFO(0, timeout, IS_DOUBLE, 0) | ||
| ZEND_ARG_TYPE_INFO(0, retry_interval, IS_LONG, 0) | ||
| ZEND_ARG_TYPE_INFO(0, status, _IS_BOOL, 0) | ||
| ZEND_ARG_INFO(0, failure_callbac) |
There was a problem hiding this comment.
"failure_callbac" - typo?
|
Closing in favor of #76, the unifying of branches be better done elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.