Skip to content

Commit

Permalink
build: re-enable NU1605
Browse files Browse the repository at this point in the history
- re-enable NU1605 warning;
- fix package versions so there are no package downgrades which
caused NU1605 errors.
  • Loading branch information
webwarrior-ws committed Feb 8, 2024
1 parent 81c424d commit a59b2d6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,5 @@
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<DebugType>embedded</DebugType>
<WarningsNotAsErrors>$(WarningsNotAsErrors);NU1605</WarningsNotAsErrors>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<PackageReference Update="FSharp.Core"
Condition="'$(MSBuildProjectExtension)' == '.fsproj' And '$(DisableImplicitFSharpCoreReference)' != 'true' And '$(UpdateImplicitFSharpCoreReference)' != 'false'"
IsImplicitlyDefined="true"
Version="6.0.0" />
Version="[6.0.7]" />
</ItemGroup>
<!-- Download and copy packages used by Fornax as these are no longer managed using Paket -->
<ItemGroup>
Expand Down
6 changes: 3 additions & 3 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@
<PackageVersion Include="Ionide.ProjInfo.FCS" Version="0.58" />
<PackageVersion Include="Ionide.ProjInfo.Sln" Version="0.58" />
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="5.0" />
<PackageVersion Include="Microsoft.Build" Version="16.11" />
<PackageVersion Include="Microsoft.Build.Framework" Version="16.11.0" />
<PackageVersion Include="Microsoft.Build" Version="17.2.0" />
<PackageVersion Include="Microsoft.Build.Framework" Version="17.2.0" />
<PackageVersion Include="Microsoft.Build.Locator" Version="1.4.1" />
<PackageVersion Include="Microsoft.Build.Tasks.Core" Version="17.2.0" />
<PackageVersion Include="Microsoft.Build.Tasks.Git" Version="1.0" />
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="16.11.0" />
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="17.2.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.2" />
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="3.10" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="3.10" />
Expand Down

0 comments on commit a59b2d6

Please sign in to comment.