Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy in Lark #1101

Merged
merged 30 commits into from
Nov 25, 2021
Merged

Deploy in Lark #1101

merged 30 commits into from
Nov 25, 2021

Conversation

abhishek-iiit
Copy link
Member

@abhishek-iiit abhishek-iiit commented Jul 16, 2021 •
edited
Loading

Deploy in Lark

Screenshot from 2021-07-29 22-03-17
Screenshot from 2021-07-29 22-03-31
Screenshot from 2021-07-29 22-03-38

@abhishek-iiit abhishek-iiit requested a review from a team as a code owner July 16, 2021 15:00
@abhishek-iiit abhishek-iiit added GSoD 2021 how to guide PR related to How-to-Guide section labels Jul 16, 2021
@abhishek-iiit abhishek-iiit self-assigned this Jul 16, 2021
@abhishek-iiit
Copy link
Member Author

Linked to issue #896

proudofsimin
proudofsimin requested changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you modify this PR according to the comments in #1098 ? Thank you.

@abhishek-iiit
Copy link
Member Author

Changes made as suggested :)

@abhishek-iiit abhishek-iiit requested a review from vasvi-sood July 23, 2021 03:53
proudofsimin
proudofsimin approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you, but don't forget to add this one.
image

vasvi-sood
vasvi-sood approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@vasvi-sood vasvi-sood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks perfect to me!

Rohitesh-Kumar-Jain
Rohitesh-Kumar-Jain approved these changes Aug 1, 2021
View reviewed changes
Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proofread

huan
huan previously requested changes Sep 7, 2021
View reviewed changes
Copy link
Member

@huan huan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- docusaurus/static/img/docs/howto/IM_platform/deploy-lark.webp
+ docusaurus/static/img/docs/howto/deploy-lark/deploy-lark.webp

@Soumi7 Soumi7 mentioned this pull request Sep 9, 2021
Merged
@abhishek-iiit
Copy link
Member Author

Please rename docusaurus/static/img/docs/howto/IM_platform/deploy-lark.webp to docusaurus/static/img/docs/howto/deploy-lark/deploy-lark.webp

I added the changes as suggested previously. will delete the IM_platform folder at the end of the merging of all PR :)

@lijiarui lijiarui requested a review from Roxanne718 September 28, 2021 16:51
huan
huan approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rohitesh-Kumar-Jain
Copy link
Contributor

ping @lijiarui

lijiarui
lijiarui previously requested changes Oct 17, 2021
View reviewed changes
Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I preview the doc, I found I cannot find the content in the sidebar, I think we should fix this first.

image

@Rohitesh-Kumar-Jain
Copy link
Contributor

@abhishek-iiit I don't see the requested changes addresses.

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain removed the request for review from lijiarui October 28, 2021 11:39
@abhishek-iiit
Copy link
Member Author

abhishek-iiit commented Oct 28, 2021 •
edited
Loading

@abhishek-iiit I don't see the requested changes addresses.

Sorry, I forgot to mention that I did the changes as addressed here in this #1139 PR

Rohitesh-Kumar-Jain
Rohitesh-Kumar-Jain approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right, I wasn't aware that you changed that there 😅

@abhishek-iiit
Copy link
Member Author

Yes you are right, I wasn't aware that you changed that there 😅

Actually I forgot to mention it here :( Sorry 😅

@Rohitesh-Kumar-Jain
Copy link
Contributor

ping @lijiarui

@shraddhavp shraddhavp disabled auto-merge November 17, 2021 03:41
@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain removed the request for review from lijiarui November 25, 2021 13:13
@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain dismissed lijiarui’s stale review November 25, 2021 13:17

I believe all the changes have been implemented and the review has become stale

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain merged commit c641798 into wechaty:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasvi-sood vasvi-sood vasvi-sood approved these changes

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain approved these changes

@proudofsimin proudofsimin proudofsimin approved these changes

@huan huan huan approved these changes

@lijiarui lijiarui lijiarui left review comments

@Roxanne718 Roxanne718 Awaiting requested review from Roxanne718

Assignees

@abhishek-iiit abhishek-iiit

Labels
GSoD 2021 how to guide PR related to How-to-Guide section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abhishek-iiit @Rohitesh-Kumar-Jain @huan @lijiarui @proudofsimin @vasvi-sood @shraddhavp