-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is Wechaty sub-section of the Introduction section #871
Conversation
…y sub-section, Introduction section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall your documentation is really great! I point out some minor corrections and hope we could make it better together!
Thanks to @proudofsimin for your great review & suggestions of how to follow the Google Developer Documentation Style Guide! It's very important for our docs to follow those guides because we must be consistent across all docs, especially we have many writers work together. I'm thinking about whether we can find a linter (linting tool) for enforce those documentation styles, would love to add it to our CI system if there's any. |
Hi @huan, I don't think there is a linter that follows the Google developer documentation style guide, but for programming languages, there are separate linters, but I don't think we need that. So we have to make our linter according to the Google developer documentation style guide, but that would be very hard and can be considered a long process. So as of now, I would suggest making a separate markdown file that lists all the style guide to follow for Wechaty. In addition to it, I want to add some miscellaneous points which can make the Wechaty workflow better:
|
Hi @huan, Very great suggestions! but unfortunately I didn't find it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great work
ping @huan |
hi @Rohitesh-Kumar-Jain As GSoD Project PR Review Rules in https://github.com/wechaty/wechaty.js.org/issues/1045 This PR should follow our rules and get enough approval, then I will review this PR. So I remove the |
Hi @chris-4444 Wechaty committee requested review from teammates. Could you review/ sign off it and add a tag |
Reviewed.
Well. I have merged the two files and changed it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nibble0101 Thank you very much for this great PR!
@proudofsimin @Rohitesh-Kumar-Jain @chris-4444 Thank you very much for the review comments and the approvals.
This PR has been in the queue for a long time, and it has already fulfilled the requirements to be merged with three approvements:
- Approved by the teammate (+1)
- Approved by the volunteer team (+2)
Could you please help yourself to merge this PR for the community?
And I'd like to encourage all of our technical writers to merge a PR for the community, whenever the PR has fulfilled the requirements, and you believe it's good to be merged.
Thank you very much!
@Rohitesh-Kumar-Jain Can you merge this? I have failed to merge because either the base branch is protected or because I am the one who opened the PR. I am not exactly sure why. |
I noticed that @lijiarui has required changes and it might be the blocker of merging this PR. @nibble0101 Could you please resolve the change request from @lijiarui and ask her to approve this PR and try again to merge? |
I have worked on the issues she raised and even requested another review from her. |
ping @lijiarui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the IM name, then I will approve this PR. Thanks!
Improve the Introduction and Explanation sections project
This is What is Wechaty sub-section of the Introduction section