Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wechaty getting started sub-section of the Introduction section #899

Merged
merged 17 commits into from
Aug 2, 2021
Merged

Wechaty getting started sub-section of the Introduction section #899

merged 17 commits into from
Aug 2, 2021

Conversation

nibble0101
Copy link
Contributor

Improve the Introduction and Explanation sections project

Section Sub-section Technical Writer
Introduction Wechaty getting started Joseph Mawa

This is Getting started with Wechaty sub-section of the Introduction section

image
image
image

@nibble0101 nibble0101 requested review from a team as code owners May 26, 2021 11:22
@nibble0101 nibble0101 mentioned this pull request May 26, 2021
Open
@nibble0101 nibble0101 added GSoD 2021 introduction Pull requests that update introduction section of the documentation labels May 26, 2021
@Rohitesh-Kumar-Jain
Copy link
Contributor

The documentation patch looks good to me, I would like to appreciate you for attaching appropriate links in the documentation. Great Work !

@nibble0101
Copy link
Contributor Author

The documentation patch looks good to me, I would like to appreciate you for attaching appropriate links in the documentation. Great Work !

Thanks for the review

@nibble0101 nibble0101 self-assigned this May 28, 2021
proudofsimin
proudofsimin approved these changes May 29, 2021
View reviewed changes
Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. Maybe next time we could try to eliminate the frequency of using "You" to start a sentence. It sounds a bit commanding.
FYI: self-editing

Rohitesh-Kumar-Jain
Rohitesh-Kumar-Jain reviewed May 29, 2021
View reviewed changes
Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, do let me know when you think the PR is ready to get merged : )

@nibble0101
Copy link
Contributor Author

@proudofsimin 💯 Okay then we shall limit the use of you at the beginning of a sentence in the subsequent iterations of the docs.

@Rohitesh-Kumar-Jain We are ready for merging. We have links that are not pointing to the exact location because the doc. is still evolving. At the moment we are using placeholders. We shall start replacing them in the next iterations when the entire doc. is 60 - 80 % finished.

Rohitesh-Kumar-Jain
Rohitesh-Kumar-Jain approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ready to be merged
ping @huan

lijiarui
lijiarui requested changes Jun 9, 2021
View reviewed changes
Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should change docusaurus/docs/getting-started-with-wechaty.md to docusaurus/docs/getting-started-with-wechaty.mdx

@lijiarui
Copy link
Member

hi @Rohitesh-Kumar-Jain As GSoD Project PR Review Rules in https://github.com/wechaty/wechaty.js.org/issues/1045

This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

@proudofsimin
Copy link
Contributor

hi @Rohitesh-Kumar-Jain As GSoD Project PR Review Rules in #1045

This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

Hi @chris-4444 could you review and add the tag ready to merge afterwards? Thank you.

@nibble0101 nibble0101 requested a review from chris-4444 July 12, 2021 10:56
@Rohitesh-Kumar-Jain
Copy link
Contributor

@chris-4444 I would like you to once go through the PR, and approve when you think it's ready to get merged.

@lijiarui
Copy link
Member

hi @chris-4444 , as @Rohitesh-Kumar-Jain said, I will remove ready to merge tag, when it got enough approval, feel free to add it again.

chris-4444
chris-4444 approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@chris-4444 chris-4444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nibble0101 nibble0101 mentioned this pull request Jul 15, 2021
Open
@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain mentioned this pull request Jul 18, 2021
Closed
lijiarui
lijiarui requested changes Jul 18, 2021
View reviewed changes
docusaurus/docs/getting-started-with-wechaty.mdx Outdated Show resolved Hide resolved
docusaurus/docs/getting-started-with-wechaty.mdx Outdated Show resolved Hide resolved
@nibble0101 nibble0101 requested a review from lijiarui July 19, 2021 19:40
lijiarui
lijiarui requested changes Jul 29, 2021
View reviewed changes
docusaurus/docs/getting-started-with-wechaty.mdx Outdated Show resolved Hide resolved
docusaurus/docs/getting-started-with-wechaty.mdx Outdated Show resolved Hide resolved
@nibble0101 nibble0101 requested a review from lijiarui July 30, 2021 17:24
lijiarui
lijiarui approved these changes Jul 31, 2021
View reviewed changes
Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rohitesh-Kumar-Jain
Copy link
Contributor

@nibble0101 this branch has some conflicts, pls resolve them so that we can merge this, @proudofsimin I would be glad if you may take care of merging PRs in the future : )

@nibble0101
Copy link
Contributor Author

@nibble0101 this branch has some conflicts, pls resolve them so that we can merge this, @proudofsimin I would be glad if you may take care of merging PRs in the future : )

@Rohitesh-Kumar-Jain I think it is fine now.

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain merged commit 1f423e4 into wechaty:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-4444 chris-4444 chris-4444 approved these changes

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain approved these changes

@proudofsimin proudofsimin proudofsimin approved these changes

@lijiarui lijiarui lijiarui approved these changes

Assignees

@nibble0101 nibble0101

Labels
GSoD 2021 introduction Pull requests that update introduction section of the documentation ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nibble0101 @Rohitesh-Kumar-Jain @lijiarui @proudofsimin @chris-4444