Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added wechaty-class section #913

Merged
merged 9 commits into from
Sep 8, 2021
Merged

added wechaty-class section #913

merged 9 commits into from
Sep 8, 2021

Conversation

shraddhavp
Copy link
Contributor

This PR is for Wechaty Class section
linking #890

@shraddhavp shraddhavp requested a review from a team as a code owner May 31, 2021 09:12
@shraddhavp shraddhavp requested review from a team and huan May 31, 2021 12:49
Rohitesh-Kumar-Jain
Rohitesh-Kumar-Jain approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉 @shraddhavp

proudofsimin
proudofsimin approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@lijiarui
Copy link
Member

hi @Rohitesh-Kumar-Jain As GSoD Project PR Review Rules in https://github.com/wechaty/wechaty.js.org/issues/1045

This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

@Rohitesh-Kumar-Jain
Copy link
Contributor

@Soumi7 We would be glad if you may once go through the PR, and either request for changes or approve the PR.

Soumi7
Soumi7 approved these changes Jul 17, 2021
View reviewed changes
Copy link
Contributor

@Soumi7 Soumi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rohitesh-Kumar-Jain
Copy link
Contributor

@huan I can't merge this on my own, as we don't have 3 approving reviews

huan
huan approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please read and follow #1257, and feel free to help yourself to merge it by following the merge workflow.

Thank you very much!

@shraddhavp shraddhavp mentioned this pull request Sep 8, 2021
Closed
@shraddhavp shraddhavp merged commit 563283b into master Sep 8, 2021
@shraddhavp shraddhavp deleted the new_refer branch September 8, 2021 05:27
This was referenced Sep 8, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain approved these changes

@Soumi7 Soumi7 Soumi7 approved these changes

@proudofsimin proudofsimin proudofsimin approved these changes

@huan huan huan approved these changes

Assignees
No one assigned
Labels
GSoD 2021 references
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shraddhavp @lijiarui @Rohitesh-Kumar-Jain @huan @proudofsimin @Soumi7