Remove HTTP2Settings from ServerParams
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsko
force-pushed
the
edsko/http2settings
branch
from
33eb58f to
8e7a483
Compare
This was a relatively common pattern: ```haskell server <- mkGrpcServer serverParams $ .. forkServer serverParams serverConfig server $ \runningServer -> .. ``` but it is misleading: notice that the `serverParams` need to be passed _twice_, even though on call to `forkServer` we need _only_ the `HTTP2Settings`, and on the call to `mkGrpcServer` we need everything in `ServerParams` _except_ the `HTTP2Settings`: they are completely separate. This gets even more confusing in a pattern such as this: ```haskell server <- mkGrpcServer def $ .. forkServer def serverConfig server $ \runningServer -> .. ``` where we are using `def` in both places; becomes quite easy to make a change in the wrong place, and then be confused that it didn't take effect. We are now separating these two values out completely.
edsko
force-pushed
the
edsko/http2settings
branch
from
8e7a483 to
036133f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a relatively common pattern:
but it is misleading: notice that the
serverParamsneed to be passed twice, even though on call toforkServerwe need only theHTTP2Settings, and on the call tomkGrpcServerwe need everything inServerParamsexcept theHTTP2Settings: they are completely separate. This gets even more confusing in a pattern such as this:where we are using
defin both places; becomes quite easy to make a change in the wrong place, and then be confused that it didn't take effect. We are now separating these two values out completely.