php 8 error handler param incompatibility fix #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-1
to
-4
| /.idea/ | ||
| /composer.lock | ||
| /composer.phar | ||
| /vendor/ |
| Either run | ||
|
|
||
| ```bash | ||
| $ composer require ggets/phpagi ^2.20 |
|
|
||
| Support for phpagi is available from the project website. | ||
|
|
||
| * https://github.com/ggets/phpagi |
| "require": {} | ||
| } | ||
| { | ||
| "name": "ggets/phpagi", |
Comment on lines
+3
to
+13
| "description": "PHPAGI is a PHP class for the Asterisk Gateway Interface.", | ||
| "type": "library", | ||
| "license": "LGPL-2.1-or-later", | ||
| "autoload": { | ||
| "classmap": [ | ||
| "src/phpagi.php", | ||
| "src/phpagi-asmanager.php" | ||
| ] | ||
| }, | ||
| "require": {} | ||
| } |
There was a problem hiding this comment.
I can't see any difference.
It is not good idea to commit new Line Endings
|
Honestly, I don't remember much about these changes. From what I can recall there were 2 relevant changes, but I only seem to find one now. |
|
Oh now I see they were on different commits, nevermind. |
|
I must've gotten the commits mixed, sorry about that. Just ignore the PR and if you want to, you can edit the two files yourself. You only need to specify the default for that parameter and the error handler fix from the other commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.