💄 style: improve navigation bar & metadata wrapping #425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves wrapping of navigation bar icons —grouping them together for wrapping— and post metadata (see screenshots).
Changes
Accessibility
Improved: adds
aria-hidden="true"
to the separator. This prevents screen readers from announcing decorative content that could be distracting or redundant.The list structure (
<li>
elements) already provides sufficient context for understanding that these are related but separate pieces of information. Before, the screen reader would announce something like "January 1, 2024 bullet 5 min read". Witharia-hidden="true"
, the screen reader would simply announce: "January 1, 2024 5 min read"Tabbing works as before.
Screenshots
Before
Note:
After
Before
Note:
After
Note how the Tags separator starts where one would expect. Before, with the forced non-breaking spaces, it would include space before the separator.
Type of change
Checklist
theme.toml
with a sane default for the featureconfig.toml
commentstheme.toml
comments