Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGAGE-2716] Add custom breaks modal #591

Merged

Conversation

MarcusviniciusLsantos
Copy link
Collaborator

Description

Type of Change

    • Bugfix
    • Feature
    • Code style update (formatting, local variables)
    • Refactoring (no functional changes, no api changes)
    • Tests
    • Other

Motivation and Context

  • New config to personalization status

Summary of Changes

  • Add modal
  • Add Form logic
  • Add list Logic
  • Add translations
  • Add mocks

Design Files

Demonstration

image

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 12.90323% with 54 lines in your changes missing coverage. Please review.

Project coverage is 49.84%. Comparing base (4b01de0) to head (47d9b4f).

Files with missing lines Patch % Lines
...tings/SettingsProjectOptions/CustomBreakOption.vue 11.47% 54 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
- Coverage   50.21%   49.84%   -0.37%     
==========================================
  Files         181      182       +1     
  Lines        6265     6327      +62     
  Branches     1433     1443      +10     
==========================================
+ Hits         3146     3154       +8     
- Misses       3119     3173      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcusviniciusLsantos MarcusviniciusLsantos changed the base branch from main to feature/pause-status February 10, 2025 19:54
@MarcusviniciusLsantos MarcusviniciusLsantos merged commit e0da7aa into feature/pause-status Feb 10, 2025
1 check passed
@MarcusviniciusLsantos MarcusviniciusLsantos deleted the feature/custom-breaks-modal branch February 10, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants