-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added line-height to button properties #86
Conversation
sass/components/button/_button.scss
Outdated
@@ -20,6 +20,7 @@ $default-component-button-properties:( | |||
textAlign: center, | |||
disabledColor: #dddddd, | |||
disabledTextColor: getThemeProperty(textColorLight), | |||
lineHeight: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the default should be "inherit". This doesn't cause issues with previous sites (I tested with fairview evergreen).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Summary
Testing Steps
Issues/Concerns
Git Flow