Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added line-height to button properties #86

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Added line-height to button properties #86

merged 6 commits into from
Feb 22, 2024

Conversation

aletail
Copy link
Member

@aletail aletail commented Feb 21, 2024

Summary

Added line-height to button properties

Testing Steps

  • Test with any site, confirm the button has a line-height of 1
  • Confirm you can set the line height through properties

Issues/Concerns

  • This issue came up with Otto QA, the line height set on the paragraph tag of 1.65 was adding to the vertical padding
  • An alternative would be to attempt offset the vertical padding, but is difficult to calculate
  • Another alternative would be to set the line height to inherit and set the line height locally where needed
  • All in all, let me know what you think

Git Flow

  • DO NOT delete "release/*" or "hotfix/*" branches after merging a PR. These are used to publish the next release, and they are deleted automatically.
  • "Squash and merge" is good on "feature/*" into "develop"
  • "Create a merge commit" is good on "release/*" or "hotfix/*" into "main"
  • With npm repositories, the version number must be incremented manually, before merging the release.

@aletail aletail requested a review from tiller1010 February 21, 2024 13:08
@aletail aletail added the patch label Feb 21, 2024
@aletail aletail changed the base branch from develop to main February 21, 2024 13:08
@@ -20,6 +20,7 @@ $default-component-button-properties:(
textAlign: center,
disabledColor: #dddddd,
disabledTextColor: getThemeProperty(textColorLight),
lineHeight: 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the default should be "inherit". This doesn't cause issues with previous sites (I tested with fairview evergreen).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this makes sense

@aletail aletail requested a review from tiller1010 February 22, 2024 13:40
Copy link
Member

@tiller1010 tiller1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aletail aletail merged commit c03c73d into main Feb 22, 2024
1 check passed
@github-actions github-actions bot deleted the hotfix/2.1.13 branch February 22, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants