-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added desktop directions (right to left, left to right, top to bottom, bottom to top) #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The direction is only set in
@media screen and (min-width: 1366px)
, so it reverts back to the initial direction if there isn't atablet-
class too.
With npm repositories, the version number must be incremented manually, before merging the release.
- We'll need to update package.json to 2.1.14
&.desktop-btt{ | ||
flex-direction: column-reverse; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still duplicate rules inside of the media query.
We could also still make use of breakpointDesktop
, by simply moving those styles outside of the media query, but still within the @each
/*
DESKTOP BREAKPOINTS
Loop through each desktop defined breakpoint
*/
@each $label, $breakpoint in getThemeProperty(breakpointDesktop){
/* Flex Container Direction */
.flex-container{
&.#{$label}-ltr{
flex-direction: row;
}
&.#{$label}-rtl{
flex-direction: row-reverse;
}
&.#{$label}-ttb{
flex-direction: column;
}
&.#{$label}-btt{
flex-direction: column-reverse;
}
}
@media screen and (min-width: $breakpoint) {
.#{$label}-half{
width: 0.5%;
min-height: 1px;
}
@for $i from 1 through 100 {
.#{$label}-#{$i} {
width: round(percentage(math.div($i, 100)));
}
}
.#{$label}-auto{
width: auto;
}
.#{$label}-hide{
display: none;
}
.#{$label}-show{
display: inherit;
}
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still duplicate rules inside of the media query.
Right, not sure how to get around this. The "desktop-" rules outside of the mediaquery act as a default/fall back mostly - we could rename those to "default-" ....but that would be a major change and require more class tags to be used in the html. If we are looking to optimize this and remove the duplicate rules I think we should handle in a separate PR
We could also still make use of breakpointDesktop, by simply moving those styles outside of the media query, but still within the @each
But this would add those for each breakpoint added to the desktop list and they would exist outside of their related mediaquery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "desktop-" rules outside of the mediaquery act as a default/fall back mostly...
...this would add those for each breakpoint added to the desktop list and they would exist outside of their related mediaquery
This makes sense. Everything looks good then!
Summary
Testing Steps
Issues/Concerns
Git Flow