Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/change usecase structure #69

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

werlleyg
Copy link
Owner

@werlleyg werlleyg commented Dec 6, 2024

Evidência

image

Summary by CodeRabbit

Notas de Lançamento

  • Novos Recursos

    • Introduzidas novas interfaces para GetMovieUsecase, GetMovieSuggestionUsecase e GetMoviesUsecase, facilitando a execução de operações relacionadas a filmes.
    • Implementação de novas classes para GetMovieUsecaseImpl, GetMovieSuggestionUsecaseImpl e GetMoviesUsecaseImpl, melhorando a estrutura de recuperação de dados.
  • Atualizações

    • Atualização da versão do pacote para 0.1.0.
    • Modificações textuais no arquivo README.md para simplificar a descrição da camada de infraestrutura.
  • Remoções

    • Remoção das implementações anteriores de GetMovieUsecaseImpl, GetMovieSuggestionUsecaseImpl e GetMoviesUsecaseImpl da camada de infraestrutura.

@werlleyg werlleyg self-assigned this Dec 6, 2024
Copy link

coderabbitai bot commented Dec 6, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

As mudanças incluem atualizações textuais no arquivo README.md, uma atualização de versão no package.json, e uma reestruturação significativa das implementações de casos de uso relacionados a filmes. As interfaces foram substituídas por classes concretas em vários arquivos de casos de uso, como GetMovieUsecase, GetMovieSuggestionUsecase e GetMoviesUsecase. Além disso, houve alterações nas declarações de exportação e nos caminhos de importação para refletir essa nova estrutura. Algumas implementações de casos de uso foram removidas do diretório de infraestrutura.

Changes

Arquivo Resumo das Mudanças
README.md Atualização textual na seção "Arquitetura" para simplificar a descrição da camada de infraestrutura.
package.json Atualização da versão de 0.0.6 para 0.1.0, sem alterações nas dependências.
src/domain/usecases/getMovie.usecase.ts Substituição da interface GetMovieUsecase por GetMovieUsecaseImpl, com métodos redefinidos.
src/domain/usecases/getMovieSuggestion.usecase.ts Substituição da interface GetMovieSuggestionUsecase por GetMovieSuggestionUsecaseImpl, com lógica complexa.
src/domain/usecases/getMovies.usecase.ts Substituição da interface GetMoviesUsecase por GetMoviesUsecaseImpl, com novos métodos de manipulação.
src/domain/usecases/index.ts Remoção da exportação de getMovieSuggestion.
src/domain/usecases/interfaces/getMovie.usecase.ts Introdução da nova interface GetMovieUsecase com tipos Params e Model.
src/domain/usecases/interfaces/getMovieSuggestion.usecase.ts Introdução da nova interface GetMovieSuggestionUsecase com tipos Params e Model.
src/domain/usecases/interfaces/getMovies.usecase.ts Introdução da nova interface GetMoviesUsecase com tipos Params e Model.
src/infrastructure/usecases/getMovie.usecase.ts Remoção da classe GetMovieUsecaseImpl.
src/infrastructure/usecases/getMovieSuggestion.usecase.ts Remoção da classe GetMovieSuggestionUsecaseImpl.
src/infrastructure/usecases/getMovies.usecase.ts Remoção da classe GetMoviesUsecaseImpl.
src/main/factories/usecases/getMovie.factory.ts Atualização dos caminhos de importação para GetMovieUsecase e GetMovieUsecaseImpl.
src/main/factories/usecases/getMovieSuggestion.factory.ts Atualização dos caminhos de importação para GetMovieSuggestionUsecase e GetMovieSuggestionUsecaseImpl.
src/main/factories/usecases/getMovies.factory.ts Atualização dos caminhos de importação para GetMoviesUsecase e GetMoviesUsecaseImpl.
tests/infrastructure/usecases/getMovieSuggestionUsecaseImpl.spec.ts Atualização do caminho de importação para GetMovieSuggestionUsecaseImpl.
tests/infrastructure/usecases/getMovieUsecaseImpl.spec.ts Atualização do caminho de importação para GetMovieUsecaseImpl.
tests/infrastructure/usecases/getMoviesUsecaseImpl.spec.ts Atualização do caminho de importação para GetMoviesUsecaseImpl.
tests/main/factories/usecases/getMovie.spec.ts Atualização do caminho de importação para GetMovieUsecaseImpl.
tests/main/factories/usecases/getMovieSuggestion.spec.ts Atualização do caminho de importação para GetMovieSuggestionUsecaseImpl.
tests/main/factories/usecases/getMovies.spec.ts Atualização do caminho de importação para GetMoviesUsecaseImpl.

Suggested labels

enhancement

🐰 "Mudanças no código, que alegria,
Novas classes dançam em harmonia.
Interfaces foram deixadas para trás,
Com sugestões de filmes, tudo é capaz!
Em cada linha, um salto de felicidade,
Vamos celebrar essa nova realidade!" 🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between e92ccb7 and 1d4e03c.

⛔ Files ignored due to path filters (1)
  • docs/images/architecture-diagram.png is excluded by !**/*.png
📒 Files selected for processing (22)
  • README.md (1 hunks)
  • package.json (1 hunks)
  • src/domain/usecases/getMovie.usecase.ts (1 hunks)
  • src/domain/usecases/getMovieSuggestion.usecase.ts (1 hunks)
  • src/domain/usecases/getMovies.usecase.ts (1 hunks)
  • src/domain/usecases/index.ts (0 hunks)
  • src/domain/usecases/interfaces/getMovie.usecase.ts (1 hunks)
  • src/domain/usecases/interfaces/getMovieSuggestion.usecase.ts (1 hunks)
  • src/domain/usecases/interfaces/getMovies.usecase.ts (1 hunks)
  • src/domain/usecases/interfaces/index.ts (1 hunks)
  • src/infrastructure/usecases/getMovie.usecase.ts (0 hunks)
  • src/infrastructure/usecases/getMovieSuggestion.usecase.ts (0 hunks)
  • src/infrastructure/usecases/getMovies.usecase.ts (0 hunks)
  • src/main/factories/usecases/getMovie.factory.ts (1 hunks)
  • src/main/factories/usecases/getMovieSuggestion.factory.ts (1 hunks)
  • src/main/factories/usecases/getMovies.factory.ts (1 hunks)
  • tests/infrastructure/usecases/getMovieSuggestionUsecaseImpl.spec.ts (1 hunks)
  • tests/infrastructure/usecases/getMovieUsecaseImpl.spec.ts (1 hunks)
  • tests/infrastructure/usecases/getMoviesUsecaseImpl.spec.ts (1 hunks)
  • tests/main/factories/usecases/getMovie.spec.ts (1 hunks)
  • tests/main/factories/usecases/getMovieSuggestion.spec.ts (1 hunks)
  • tests/main/factories/usecases/getMovies.spec.ts (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@werlleyg werlleyg merged commit 6b6f8b9 into develop Dec 6, 2024
1 check passed
@werlleyg werlleyg deleted the refactor/change-usecase-structure branch December 6, 2024 03:35
@werlleyg werlleyg linked an issue Dec 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor/change-usecase-structure
1 participant