Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GROWI AI Next #9492

Open
wants to merge 123 commits into
base: master
Choose a base branch
from
Open

feat: GROWI AI Next #9492

wants to merge 123 commits into from

Conversation

miya
Copy link
Member

@miya miya commented Dec 17, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1ec1141

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

miya and others added 3 commits January 16, 2025 06:37
@miya
Refactor path condition creation to use convertPathPatternsToRegExp f…
f38352c 
…or improved pattern handling
@miya
VectorStoreFile no longer waits for creation
da0041c
@miya
Merge pull request #9545 from weseek/feat/160044-implement-logic-for-…
03377b8 
…creating-pecialized-vector-store

feat: Implement logic for creating specialized VectorStore
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 16, 2025
View reviewed changes
apps/app/src/features/openai/server/routes/ai-assistant.ts

// check if the value is a grob pattern path
if (value.includes('*')) {
return isGrobPatternPath(value) && isCreatablePage(value.replace('*', ''));

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This replaces only the first occurrence of '*'.

Copilot Autofix AI 5 days ago

To fix the problem, we need to ensure that all occurrences of the asterisk (*) in the value string are replaced. This can be achieved by using a regular expression with the global flag (g). This change ensures that all instances of the asterisk are replaced, not just the first one.

Suggested changeset 1
apps/app/src/features/openai/server/routes/ai-assistant.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/apps/app/src/features/openai/server/routes/ai-assistant.ts b/apps/app/src/features/openai/server/routes/ai-assistant.ts
--- a/apps/app/src/features/openai/server/routes/ai-assistant.ts
+++ b/apps/app/src/features/openai/server/routes/ai-assistant.ts
@@ -66,3 +66,3 @@
         if (value.includes('*')) {
-          return isGrobPatternPath(value) && isCreatablePage(value.replace('*', ''));
+          return isGrobPatternPath(value) && isCreatablePage(value.replace(/\*/g, ''));
         }
EOF
@@ -66,3 +66,3 @@
if (value.includes('*')) {
return isGrobPatternPath(value) && isCreatablePage(value.replace('*', ''));
return isGrobPatternPath(value) && isCreatablePage(value.replace(/\*/g, ''));
}
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
miya and others added 26 commits January 17, 2025 02:11
@miya
impl createConditionForCreateAiAssistant
47996e2
@miya
Imprv types
c85c8bb
@miya
imprv conditions
4af55fc
@miya
add comment
17b9207
@miya
imprv access control logic for owner scope
d828442
@miya
add ExternalUserGroupRelation.
cd7c054
@miya
impl
27cf3cd
@miya
Update pagePathPatterns handling in AiAssistantManagementModal for dy…
f033164 
…namic path creation
@miya
fix lint error
37a57b8
@miya
fix debug log
22f60ab
@yuki-takei
Merge pull request #9552 from weseek/feat/160099-condition-for-owners…
e8342e4 
…-access-scope

feat: Condition for owners access scope
@miya
Merge branch 'feat/growi-ai-next' into feat/159176-implementation-of-…
9630de7 
…an-api-client-for-ai-assistant
@miya
add IApiv3AiAssistantCreateParams
6e3173c
@miya
Merge pull request #9561 from weseek/feat/159176-implementation-of-an…
7367ca9 
…-api-client-for-ai-assistant

feat: Implementation of an API client for AiAssistant
@miya
impl
f2ee61c
@miya
fix comment
693312e
@miya
add debug looger
8be3e4f
@yuki-takei
Merge pull request #9562 from weseek/feat/160518-enable-learning-rest…
b6259b1 
…ricted-page-exact-path

feat: Enable learning when a RESTRICTED page is accessed via its exact path
@miya
Use $in
93f6b0b
@miya
Merge pull request #9569 from weseek/fix/query-for-create-condition-f…
a62c1c6 
…or-create-ai-assistant

fix(ai): Query for createConditionForCreateAiAssistant
@miya
Merge branch 'master' into feat/growi-ai-next
a770ebb
@miya
Revert "Merge branch 'master' into feat/growi-ai-next"
db3f03f 
This reverts commit a770ebb, reversing
changes made to a62c1c6.
@miya
Reapply "Merge branch 'master' into feat/growi-ai-next"
f9d65f9 
This reverts commit db3f03f.
@miya
Revert "Merge pull request #9572 from weseek/support/upgrade-react"
3c03ef6 
This reverts commit 6eb1da1, reversing
changes made to 5e0e337.
@miya
Reapply "Merge pull request #9572 from weseek/support/upgrade-react"
bbf8c87 
This reverts commit 3c03ef6.
@miya
Merge branch 'master' into feat/growi-ai-next
1ec1141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miya @yuki-takei