Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imprv: Types for crowi facade object and configManager #9580

Merged
merged 36 commits into from
Jan 27, 2025
Merged

Imprv: Types for crowi facade object and configManager #9580

merged 36 commits into from
Jan 27, 2025

Conversation

yuki-takei
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4b0769a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yuki-takei
Copy link
Member Author

@mergify queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jan 23, 2025
@mergify
Merge of #9580
5551124
@mergify mergify bot mentioned this pull request Jan 23, 2025
Closed
15 tasks
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

miya and others added 7 commits January 27, 2025 02:34
@miya
add types
644ca4d
@yuki-takei
Merge pull request #9583 from goofmint/fix/doc-v3-logout
9e5ed8a 
support(jsdoc): add swagger document to logout.js
@yuki-takei
Merge pull request #9584 from goofmint/fix/doc-v3-mongo
fbaa1b3 
support(jsdoc): add swagger document to mongo.js
@yuki-takei
Merge pull request #9585 from goofmint/fix/doc-v3-markdown-setting
8932464 
support(jsdoc): add swagger document to markdown-setting.js
@yuki-takei
Merge pull request #9586 from goofmint/fix/doc-v3-notification-setting
271d699 
support(jsdoc): add swagger document to notification-setting.js
@yuki-takei
Merge pull request #9587 from goofmint/fix/doc-v3-update-page
cf62b38 
support(jsdoc): add swagger document to page/index.ts for update page
@yuki-takei
Merge pull request #9590 from weseek/imprv/160722-make-data-migration…
c9456fb 
…-type-safe

imprv: Make data migration type safe
@yuki-takei
Copy link
Member Author

@mergify requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 27, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@yuki-takei
Copy link
Member Author

@mergify queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 27, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jan 27, 2025
@mergify
Merge of #9580
901ee9d
@mergify mergify bot mentioned this pull request Jan 27, 2025
Closed
15 tasks
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 27, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@yuki-takei
Copy link
Member Author

@mergify queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 27, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 56e4475

mergify bot added a commit that referenced this pull request Jan 27, 2025
@mergify
Merge of #9580
6773265
@mergify mergify bot mentioned this pull request Jan 27, 2025
Closed
15 tasks
@mergify mergify bot merged commit 56e4475 into feat/opentelemetry Jan 27, 2025
14 checks passed
@mergify mergify bot deleted the imprv/types-for-crowi-and-config-manager branch January 27, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuki-takei @miya