feat: provides logging and hook support for redis #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozline
reviewed
Nov 1, 2024
pkg/base/client/cache.go
Outdated
| @@ -31,11 +33,17 @@ func NewRedisClient(db int) (*redis.Client, error) { | |||
| if config.Redis == nil { | |||
| return nil, errors.New("redis config is nil") | |||
| } | |||
|
|
|||
| l := logger.GetRedisLogger() | |||
| redis.SetLogger(l) | |||
There was a problem hiding this comment.
这个setlogger在new之前不会有问题么？
我没有注意到还有这个logger，想问一下这个和我们hook有什么区别？
There was a problem hiding this comment.
一个进程只会有一个loggerObj，其他的任何logger都是对他的封装。RedisLogger也一样，只是加了四个方法来满足redis定义的接口
There was a problem hiding this comment.
client中没有logger对象，client的日志输出就是调用的全局logger，所以不会有问题
There was a problem hiding this comment.
不是啊，我是想问你 new 这个对象之前就 setlogger 了，会不会有点问题？需要放到后面吗
There was a problem hiding this comment.
不会有问题。但是在逻辑上确实应该放在初始化之后，改了
jiuxia211
previously approved these changes
Nov 4, 2024
|
LGTM |
SchwarzSail
previously approved these changes
Nov 4, 2024
|
你新的 commit 还是没有签名 |
有了有了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.