refactor: modern project structure in launch_screen #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FantasyRL
requested review from
jiuxia211
and removed request for
renbaoshuo and
mutezebra
ozline
reviewed
Nov 3, 2024
cmd/launch_screen/main.go
Outdated
| @@ -23,21 +23,28 @@ import ( | |||
| "github.com/cloudwego/netpoll" | |||
| etcd "github.com/kitex-contrib/registry-etcd" | |||
|
|
|||
| "github.com/west2-online/fzuhelper-server/pkg/base" | |||
There was a problem hiding this comment.
svr.Run()前注册退出函数，e.g.
server.RegisterShutdownHook(clientSet.Close)| @@ -19,18 +19,22 @@ package service | |||
| import ( | |||
| "context" | |||
|
|
|||
| "github.com/west2-online/fzuhelper-server/pkg/utils" | |||
|
|
|||
internal/launch_screen/pack/image.go
Outdated
| "github.com/west2-online/fzuhelper-server/kitex_gen/model" | ||
| model2 "github.com/west2-online/fzuhelper-server/pkg/db/model" |
| @@ -20,25 +20,26 @@ import ( | |||
| "fmt" | |||
| "time" | |||
|
|
|||
| "github.com/west2-online/fzuhelper-server/pkg/db/model" | |||
|
|
|||
| "github.com/west2-online/fzuhelper-server/pkg/cache" | ||
| "github.com/west2-online/fzuhelper-server/pkg/db" | ||
| "github.com/west2-online/fzuhelper-server/pkg/db/model" | ||
|
|
| "github.com/west2-online/fzuhelper-server/pkg/db" | ||
| "github.com/west2-online/fzuhelper-server/pkg/db/model" | ||
| "github.com/west2-online/fzuhelper-server/pkg/utils" | ||
|
|
| todo:use cache.go | ||
| */ | ||
|
|
||
| func (c *CacheLaunchScreen) IsLaunchScreenCacheExist(ctx context.Context, key string) bool { |
| } | ||
|
|
||
| func IsLastLaunchScreenIdCacheExist(ctx context.Context) bool { | ||
| return RedisClient.Exists(ctx, constants.LastLaunchScreenIdKey).Val() == 1 | ||
| func (c *CacheLaunchScreen) IsLastLaunchScreenIdCacheExist(ctx context.Context) bool { |
|
@jiuxia211 @SchwarzSail 快来review然后合了 |
jiuxia211
previously approved these changes
Nov 3, 2024
SchwarzSail
reviewed
Nov 3, 2024
| @@ -52,7 +60,7 @@ func (s *LaunchScreenServiceImpl) CreateImage(stream launch_screen.LaunchScreenS | |||
| req.Image = bytes.Join([][]byte{req.Image, fileReq.Image}, []byte("")) | |||
| } | |||
|
|
|||
| pic, err := service.NewLaunchScreenService(stream.Context()).CreateImage(req) | |||
| pic, err := service.NewLaunchScreenService(stream.Context(), s.ClientSet).CreateImage(req) | |||
There was a problem hiding this comment.
这边在注入依赖的时候是把 ClientSet 全部注入进去吗，还是注入 service 所需要的 client？
There was a problem hiding this comment.
我偏向于后者，需要你在 service 定义出你所需要的 client 吧（
ozline
changed the title
|
@FantasyRL 修一下 ci，帮你解决冲突了，后面应该也由你自己来解决冲突，基本功了属于是 |
|
@jiuxia211 cc |
Signed-off-by: FanR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to #71