fix some problems in paper and url service #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penqee
requested review from
mutezebra,
ozline,
jiuxia211 and
a team
as code owners
|
接口文档已修改 |
jiuxia211
previously approved these changes
Nov 4, 2024
|
典中典 没有signed |
SchwarzSail
reviewed
Nov 5, 2024
| @@ -83,7 +85,7 @@ func UploadVersionInfo(ctx context.Context, c *app.RequestContext) { | |||
| return | |||
| } | |||
|
|
|||
| url := "http://127.0.0.1:5000/api/upload" | |||
| url := fmt.Sprintf("http://%s:5000/api/upload", constants.URLServiceName) | |||
There was a problem hiding this comment.
全部写在 constants 吧，加上注释，不然后面的人看不懂
There was a problem hiding this comment.
这个我认为不必要，接口总共10几个，全放constants不合适，并且这个模块是需要重构的
There was a problem hiding this comment.
这么多接口，全是历年卷的？
这个不是历年卷，是136url的
There was a problem hiding this comment.
136 是哪一个，之前的迁移文档我找不到了，现在还有哪些没迁移
|
你忘记传你的 key 了，可以看一下具体的操作 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url: Modified url format
paper: When it was compatible with the URL, it was found that the parameters of downloadUrl did not match the Android version and was modified.
Modifications have been made when deployed on the server