fix: solve some problems in paper and url service #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penqee
requested review from
mutezebra,
ozline,
jiuxia211 and
a team
as code owners
jiuxia211
reviewed
Nov 11, 2024
| @@ -65,7 +65,7 @@ struct Picture{ | |||
|
|
|||
| // 又拍云文件目录结构 | |||
| struct UpYunFileDir { | |||
| 1: required string basePath, | |||
| 1: required string base_path, | |||
There was a problem hiding this comment.
好吧，其实我的意思是说明一下为什么 base_path 这个字段使用下划线
There was a problem hiding this comment.
原本写的时候basePath才对，然后说要兼容就改成base_path了，但其实刚才我已经在别处实现了兼容，这里理应改回去，算是我漏掉了
pkg/errno/code.go
Outdated
| @@ -76,3 +76,8 @@ const ( | |||
| InternalETCDErrorCode = 50019 // ETCD错误 | |||
| InternalTraceErrorCode = 50020 // Trace错误 | |||
| ) | |||
|
|
|||
| // paper的SuccessCode是2000, 不是 10000 | |||
| const ( | |||
There was a problem hiding this comment.
不用新的const吧，加在上面就可以，单开一行加注释这样
jiuxia211
requested changes
Nov 11, 2024
| @@ -65,7 +65,7 @@ struct Picture{ | |||
|
|
|||
| // 又拍云文件目录结构 | |||
| struct UpYunFileDir { | |||
| 1: required string basePath, | |||
| 1: required string base_path, | |||
There was a problem hiding this comment.
好吧，其实我的意思是说明一下为什么 base_path 这个字段使用下划线
idl/api.thrift
Outdated
There was a problem hiding this comment.
request 和 response 的顺序 ？还是规范一点一个req一个resp，还有，PaperData 这种应该放在model里吧？
There was a problem hiding this comment.
这个PaperData是因为兼容才写的，别的地方用不到，所以就没放model了，但确实放model里比较好
pkg/errno/code.go
Outdated
| @@ -75,4 +75,7 @@ const ( | |||
| InternalQueueErrorCode = 50018 // 队列错误 | |||
| InternalETCDErrorCode = 50019 // ETCD错误 | |||
| InternalTraceErrorCode = 50020 // Trace错误 | |||
|
|
|||
| // paper的SuccessCode是2000, 不是 10000 | |||
There was a problem hiding this comment.
注释应该写：旧版Android的SuccessCode是2000，用作兼容
jiuxia211
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paper: url兼容问题
url: modified url format