-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow references for responses fixes #84 #89
Allow references for responses fixes #84 #89
Conversation
38ec1ac
to
8479edf
Compare
@westfield-labs are you still maintaining this project? |
@hornc Sorry to bother you, but I saw you did the latest merge. Any thoughts on this? |
when response_data.schema | ||
Fragment.new(['#', 'paths', path, verb, 'responses', response_code, 'schema']) | ||
when (ref = response_data['$ref']) | ||
Fragment.new(ref.split('/')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the result here? seems you are missing 'schema'
Fragment.new(ref.split('/').push('schema'))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucasrenan I'm not sure why would we missing a 'schema'
. ref
holds the value of the path to the schema definition. Eg.: in the added test it's '#/definitions/service'
. And that's exactly the path to the schema definition at the end of file: https://github.com/westfieldlabs/apivore/pull/89/files#diff-65c886d34e6323742cba1cd52731ecc5R129
24cd409
to
cb62017
Compare
cb62017
to
aac8f01
Compare
@ashoda any update on the review? |
fixes #84