Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable arm image build #24

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Enable arm image build #24

merged 5 commits into from
Jul 25, 2024

Conversation

kanya-approve
Copy link
Contributor

No description provided.

@kanya-approve
Copy link
Contributor Author

@westsurname

Comment on lines +38 to +41
images: ${{ matrix.image }}

- name: Set up QEMU
uses: docker/setup-qemu-action@v3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/marketplace/actions/build-and-push-docker-images

It's to allow building against more platforms

@westsurname
Copy link
Owner

@kanya-approve I made a change to the action in attempt to get it to run for this pull request, can you merge that change in and push again?

@kanya-approve
Copy link
Contributor Author

@kanya-approve I made a change to the action in attempt to get it to run for this pull request, can you merge that change in and push again?

done

@westsurname
Copy link
Owner

Merging as is because I can't get the images to build. Will roll back if broken.

@westsurname westsurname merged commit 6921e9e into westsurname:main Jul 25, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants