-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Torbox NZB support #39
base: main
Are you sure you want to change the base?
Conversation
shared/debrid.py
Outdated
def getHash(self): | ||
|
||
if not self._hash: | ||
self._hash = hashlib.sha1(self.fileData).hexdigest() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the correct hash, haven't fully tested it. Open to suggestions.
@hnipps if we stop the running container, replace our local files with your 2 changed files, then restart the container, would that mean the running docker container is using the new code and in theory (when Torbox is working again and with a Pro plan) should work? Or would we need to docker compose --profile blackhole up -d to get it working? |
@townsmcp you'll need to change the |
Thank you @hnipps, I added |
If it could help, I've just tested nzb with torbox a few minutes ago, and folder downloaded is in the same directory as the torrents (/mnt/remote/torbox/). BTW it worked flawlessly. |
@robertRogerPresident thanks for that. Was you getting the same error in the log even though it worked? Sadly I can’t test yet - waiting for payments to be activated again. Fingers crossed it’s soon @westsurname any updates for this PR? |
I'm testing the PR now, it works realy fine, with the usenet speed, it resolves a lot of issues. I've noticed just two bugs : in the logs, the percentage of progress displayed is divided by 100, and if a nzb upload on torbox fails, it turns in an infinte loop unless you delete the download in torbox dashboard. Thanks for your work :) Edit : Torbox seems to have a really uneven behavior with usenet, all usenet files mounted seems to point in the same file in torbox, it seems there are some bugs remaining in their FTP. I will test the webDav tomorow. |
Throws error if processing NZB without Torbox
Thanks for testing it out!
Nice catch. I'll take a look. |
Tested your new comits, when torbox is working, it works like a charm :) |
'queuedDL', 'checkingDL', 'forcedDL', 'checkingResumeData', 'moving' | ||
]: | ||
return self.STATUS_DOWNLOADING | ||
elif status in ['error', 'stalledUP', 'stalledDL', 'stalled (no seeds)', 'missingFiles']: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elif status in ['error', 'stalledUP', 'stalledDL', 'stalled (no seeds)', 'missingFiles']: | |
elif status in ['error', 'stalledUP', 'stalledDL', 'stalled (no seeds)', 'missingFiles'] or status.startswith('failed'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are we getting usenet statuses from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be a better idea to do something like status in ['error', 'stalledUP', 'stalledDL', 'stalled (no seeds)', 'missingFiles'] or status.startswith('failed')
It seems that tb returns errors of the nzb client concatenated with failed
i can't for the life of me get the nzb's to push to torbox. I've overwritten shared/debrid.py blackhole.py and blackhole_watcher.py with the files from this pr and restarted the containers, but it only sees the files and never pushes them through |
@DevinVee I dont know if it helps you any, but I used the following guide: https://wiki.kuu.co.za/en/guides/torbox-plex-setup The only thing Im finding a bit of a pain is if you request multiple media files, the ones that are ready for download on Torbox do not get processed by the script until all requested media is ready on Torbox - so if you have a slow file going into Torbox and 2 files aready there, you have to wait for everything even though it is available locally in rclone |
Yea I did exactly that. Ended up just reverting back unfortunately |
@@ -461,7 +468,7 @@ def _addFile(self, data=None, files=None): | |||
response = request.json() | |||
self.print('response info:', response) | |||
|
|||
if response.get('detail') == 'queued': | |||
if 'queued' in response.get('detail'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious about this
Hey @townsmcp , how did you manage to resolve that error? |
@titooo7 erm, I didn’t really do anything special in the end. I built the script up locally and made sure to follow the setup from #39 (comment) and signed up to Pro torbox I got the message before I signed up. Let me know if you need a referral code |
This PR does what the title says. Should resolve #37.
Main changes:
TorrentBase
->FileBase
, and applies similar renaming to all methods_addNZBFile()
methodUsenetTorbox
,TorboxNZB
, andNZB
classesblackhole.py
to account for and process.nzb
files in the watched directoryTested with *arrs and Usenet BlackHole download client with the following settings (I'm using the same directories for torrents):