-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blackhole UI #40
base: main
Are you sure you want to change the base?
Blackhole UI #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early review. Some ideas of areas of improvement
# API routes must come before the catch-all route | ||
@app.get("/api/tmdb/{media_type}/{tmdb_id}/images") | ||
async def get_tmdb_images(media_type: str, tmdb_id: int): | ||
api_key = os.getenv('TMDB_API_KEY') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a system for getting and using environment variables in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t see or know about that
No description provided.