-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/most requested stable #2159
Feature/most requested stable #2159
Conversation
For review by @polmih this week, Can you check if the documentations cover all the items in our versioning public API. |
b0141a8
to
22ca5f5
Compare
22ca5f5
to
291b2d1
Compare
291b2d1
to
11ac587
Compare
Will be ready for review once DTO guidelines are updated |
@jmealing Could you please move this documentation in the newly created section /design-patterns ? Thank you. |
@Garneauma this is not a design pattern because there is and do rely on some custom CSS. So it do belong into the component folder. Design pattern are only a pattern that is build with utilities CSS and CSS from existing component. They should not introduce any new CSS or logic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Review change requests
- Update index.json-ld "status" property to "stable"
@Garneauma @polmih added the suggested changes, though the date will likely change again right before we publish it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Apply change requests
- Update index.json-ld "status" to "stable"
571b328
to
f1680da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approved by the technical team.
We will wait for the completion of all the request in https://github.com/orgs/wet-boew/projects/4/views/1 + approval from DTO and PP before to merge it.
f1680da
to
d2c57eb
Compare
d2c57eb
to
9cc81fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested locally. Do work as expected.
9cc81fa
to
0282fd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and the recent seems to be only editorial. So the my previous testing and code review are still accurate.
Note that we did received the approval from PP and DTO to merge the component related to the ILP project.
Stabilize GC most requested feature:
DTO guidelines to follow: canada-ca/design-system#286