Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/most requested stable #2159

Merged
merged 8 commits into from
Apr 15, 2024

Conversation

jmealing
Copy link
Contributor

@jmealing jmealing commented May 10, 2023

Stabilize GC most requested feature:

  • remove provisional class
  • increase line-height to create more spacing for click/touch area
  • updated documentation in both languages

DTO guidelines to follow: canada-ca/design-system#286

@jmealing jmealing marked this pull request as draft May 10, 2023 19:02
@jmealing jmealing temporarily deployed to github-ci May 10, 2023 19:26 — with GitHub Actions Inactive
@duboisp duboisp requested a review from polmih May 15, 2023 14:43
@duboisp
Copy link
Member

duboisp commented May 15, 2023

For review by @polmih this week, Can you check if the documentations cover all the items in our versioning public API.

polmih
polmih previously requested changes May 24, 2023
@jmealing jmealing force-pushed the feature/most-requested-stable branch from b0141a8 to 22ca5f5 Compare June 14, 2023 18:38
@jmealing jmealing temporarily deployed to github-ci June 14, 2023 18:38 — with GitHub Actions Inactive
@jmealing jmealing force-pushed the feature/most-requested-stable branch from 22ca5f5 to 291b2d1 Compare June 14, 2023 19:09
@jmealing jmealing temporarily deployed to github-ci June 14, 2023 19:09 — with GitHub Actions Inactive
@jmealing jmealing force-pushed the feature/most-requested-stable branch from 291b2d1 to 11ac587 Compare June 14, 2023 19:10
@jmealing jmealing temporarily deployed to github-ci June 14, 2023 19:10 — with GitHub Actions Inactive
@jmealing
Copy link
Contributor Author

Will be ready for review once DTO guidelines are updated

@Garneauma
Copy link
Contributor

@jmealing Could you please move this documentation in the newly created section /design-patterns ? Thank you.

@duboisp duboisp added the Query: Project item Part of a github project label Nov 3, 2023
@duboisp
Copy link
Member

duboisp commented Nov 6, 2023

@Garneauma this is not a design pattern because there is and do rely on some custom CSS. So it do belong into the component folder.

Design pattern are only a pattern that is build with utilities CSS and CSS from existing component. They should not introduce any new CSS or logic.

Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Review change requests
  • Update index.json-ld "status" property to "stable"

@Garneauma Garneauma assigned jmealing and unassigned Garneauma Dec 4, 2023
@jmealing
Copy link
Contributor Author

jmealing commented Dec 5, 2023

@Garneauma @polmih added the suggested changes, though the date will likely change again right before we publish it

Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Apply change requests
  • Update index.json-ld "status" to "stable"

@duboisp duboisp removed their assignment Mar 19, 2024
@Garneauma Garneauma force-pushed the feature/most-requested-stable branch from 571b328 to f1680da Compare March 19, 2024 15:03
@Garneauma Garneauma assigned duboisp and unassigned Garneauma Mar 19, 2024
duboisp
duboisp previously approved these changes Mar 20, 2024
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved by the technical team.

We will wait for the completion of all the request in https://github.com/orgs/wet-boew/projects/4/views/1 + approval from DTO and PP before to merge it.

@duboisp duboisp removed their assignment Mar 20, 2024
Garneauma
Garneauma previously approved these changes Mar 20, 2024
@Garneauma Garneauma dismissed stale reviews from duboisp and themself via d2c57eb March 27, 2024 12:37
@Garneauma Garneauma force-pushed the feature/most-requested-stable branch from f1680da to d2c57eb Compare March 27, 2024 12:37
@Garneauma Garneauma force-pushed the feature/most-requested-stable branch from d2c57eb to 9cc81fa Compare March 27, 2024 14:54
duboisp
duboisp previously approved these changes Mar 28, 2024
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally. Do work as expected.

@duboisp duboisp removed their assignment Mar 28, 2024
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and the recent seems to be only editorial. So the my previous testing and code review are still accurate.
Note that we did received the approval from PP and DTO to merge the component related to the ILP project.

@Garneauma Garneauma merged commit 5c3bc94 into wet-boew:master Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query: Project item Part of a github project
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

5 participants