Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gc ministers #2225

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Conversation

jmealing
Copy link
Contributor

Draft of Ministers block

To do:
[ ] French

Design System PR WIP:
canada-ca/design-system#299

@Garneauma
Copy link
Contributor

@jmealing Could you please move this documentation in the newly created section /design-patterns ? Thank you.

@jmealing
Copy link
Contributor Author

jmealing commented Dec 5, 2023

@Garneauma It's been moved

Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a pattern for when there are 3 ministers or is the grid always 50% of the container whether where are 1-2-3 ministers?

@Garneauma
Copy link
Contributor

@jmealing As for build issues. Can you try clicking on the "Details" link right below the "Hide all checks" link at the bottom of each PR? This should redirect you to a console where all build errors are listed. This should help you fix any build issue remaining.

Let me know if you need help with that.

@jmealing
Copy link
Contributor Author

Is there a pattern for when there are 3 ministers or is the grid always 50% of the container whether where are 1-2-3 ministers?

@Garneauma we are recommending 50% of the container regardless of minister number at this time

Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The no-container layout is not needed in this case. The design pattern should be available in container and no-container layouts, so let's give the working example for a container layout.

@jmealing jmealing marked this pull request as ready for review January 22, 2024 20:25
@jmealing jmealing force-pushed the feature/gc-ministers branch from 8acf9f3 to 2fe7e37 Compare January 22, 2024 20:57
@jmealing jmealing force-pushed the feature/gc-ministers branch from 2fe7e37 to f711ec9 Compare January 22, 2024 20:58
@Garneauma Garneauma assigned duboisp and unassigned Garneauma Mar 18, 2024
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small addition in the schema to include the component heading.

As a note in the documentation, can you list the few variation that you provided as an example. thanks

@duboisp duboisp assigned Garneauma and unassigned duboisp Mar 19, 2024
@Garneauma Garneauma force-pushed the feature/gc-ministers branch from 0db098d to 1a20035 Compare March 19, 2024 12:36
@Garneauma Garneauma assigned duboisp and unassigned Garneauma Mar 19, 2024
duboisp
duboisp previously approved these changes Mar 19, 2024
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved by the technical team.

We will wait for the completion of all the request in https://github.com/orgs/wet-boew/projects/4/views/1 + approval from DTO and PP before to merge it.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we already had the discussion regarding the use of "col-xs-12"?

@duboisp duboisp assigned Garneauma and unassigned duboisp Mar 28, 2024
@duboisp
Copy link
Member

duboisp commented Mar 28, 2024

@Garneauma le col-xs-12 doit rester sur la colonne qui a un pull-right pour défaire son effet en small view port mais pas pour les autres colonnes.

@Garneauma Garneauma force-pushed the feature/gc-ministers branch from fd7935a to 114096d Compare April 2, 2024 13:11
@Garneauma Garneauma assigned duboisp and unassigned Garneauma Apr 2, 2024
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed again and tested again locally,

No issue and this is ready for merge when approved/coordinated with the other related PRs.

@duboisp duboisp removed their assignment Apr 3, 2024
@Garneauma Garneauma merged commit a81c158 into wet-boew:master Apr 15, 2024
1 check passed
@Garneauma
Copy link
Contributor

Rectification: this is a MINOR change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query: Project item Part of a github project
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants