-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gc ministers #2225
Feature/gc ministers #2225
Conversation
@jmealing Could you please move this documentation in the newly created section /design-patterns ? Thank you. |
4c38433
to
e6affbf
Compare
@Garneauma It's been moved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a pattern for when there are 3 ministers or is the grid always 50% of the container whether where are 1-2-3 ministers?
@jmealing As for build issues. Can you try clicking on the "Details" link right below the "Hide all checks" link at the bottom of each PR? This should redirect you to a console where all build errors are listed. This should help you fix any build issue remaining. Let me know if you need help with that. |
@Garneauma we are recommending 50% of the container regardless of minister number at this time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The no-container layout is not needed in this case. The design pattern should be available in container and no-container layouts, so let's give the working example for a container layout.
8acf9f3
to
2fe7e37
Compare
2fe7e37
to
f711ec9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small addition in the schema to include the component heading.
As a note in the documentation, can you list the few variation that you provided as an example. thanks
0db098d
to
1a20035
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approved by the technical team.
We will wait for the completion of all the request in https://github.com/orgs/wet-boew/projects/4/views/1 + approval from DTO and PP before to merge it.
1a20035
to
a6a286b
Compare
a6a286b
to
fd7935a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we already had the discussion regarding the use of "col-xs-12"?
_includes/components/gc-minister/gc-minister-special-cases.html
Outdated
Show resolved
Hide resolved
_includes/components/gc-minister/gc-minister-two-ministers.html
Outdated
Show resolved
Hide resolved
@Garneauma le |
fd7935a
to
114096d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed again and tested again locally,
No issue and this is ready for merge when approved/coordinated with the other related PRs.
Rectification: this is a MINOR change. |
Draft of Ministers block
To do:
[ ] French
Design System PR WIP:
canada-ca/design-system#299