Header: Removing main menu #2410
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pre-approved upon successful review. |
|
Need DTO approval |
Garneauma
force-pushed
the
menu-removal
branch
from
959912d to
29a89e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Header component to remove the GCWeb menu.
Looking through the history of the Header component, I noticed that an extra version was added in the version history that never took place. The version 3 and 4 were done with the same commit. Not sure why they have been separated into two versions. That said, I have fixed the component history, so now the component remains at version 4.0 (current version should be 3.0).
This update to the Header meant it was necessary to edit the Breadcrumbs component. The Breadcrumb component has been updated to version 2.0.
Although the Header has been updated to a new major version, the previous version is still supported.